fix(parquet/compress): Brotli CompressBound#884
Merged
Conversation
zeroshade
changed the title
zeroshade
approved these changes
Jul 2, 2026
Member
|
just needs a rebase |
Contributor
Author
|
@zeroshade I will have a look in a few hours, thank you for your attention. |
fallintoplace
force-pushed
the
fix-brotli-compress-bound
branch
from
3c52399 to
5cf8d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Brotli
CompressBoundnow returns the computed maximum compressed size instead of the input length. The empty-input case is also handled before the debug assertion so it remains valid with-tags assert.Why
The
Codeccontract says callers can useCompressBoundto allocate a destination buffer large enough for compressed output. Returning the input length could under-report the bound for Brotli and cause callers to allocate too little.Validation
go test ./parquet/compressgo test -tags assert ./parquet/compressPARQUET_TEST_DATA=parquet-testing/data PARQUET_TEST_BAD_DATA=parquet-testing/bad_data go test ./parquet/...