fix(app): complete Spanish translations for General settings#32220
Open
thevibestack wants to merge 1 commit into
Open
fix(app): complete Spanish translations for General settings#32220thevibestack wants to merge 1 commit into
thevibestack wants to merge 1 commit into
Conversation
I ran into incomplete Spanish translations in General Settings while using the IDE in Spanish. Added the missing keys to packages/app/src/i18n/es.ts and updated the parity test so missing translations in this section fail the build. Closes anomalyco#32095
thevibestack
force-pushed
the
spanish-general-settings
branch
from
bca24e3 to
31a94f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32095
Type of change
What does this PR do?
I ran into incomplete Spanish translations in General Settings. With the IDE set to Spanish, several labels still showed up in English.
I validated it in my local build first, then traced the missing keys in packages/app/src/i18n/es.ts and added them. I also updated the parity test to catch missing keys automatically, so we avoid this bug again.
How did you verify your code works?
Screenshots / recordings
I do not have a screenshot from a running desktop build, but the affected strings are visible in Settings → General when the language is Spanish.
Checklist