fix(tui): catch unhandled promise rejections in session operations#32178
Open
MethodWhite wants to merge 1 commit into
Open
fix(tui): catch unhandled promise rejections in session operations#32178MethodWhite wants to merge 1 commit into
MethodWhite wants to merge 1 commit into
Conversation
Three void SDK calls in the session route fire async requests without .catch(). Bun terminates the process on unhandled rejections.
github-actions
Bot
added
the
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32176
Type of change
What does this PR do?
Adds .catch(() => {}) to three void SDK calls in session/index.tsx that were missing error handlers. Bun treats unhandled promise rejections as fatal.
How did you verify your code works?
Reviewed each call site. The SDK calls are fire-and-forget (no caller uses the result), so swallowing the rejection is safe and consistent with similar patterns in the same file.
Screenshots / recordings
Not a UI change.
Checklist