fix(analytical): Fix WCC's wrong result#4623
Open
songqing wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@zhanglei1949 please help a review |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
siyuan0322
approved these changes
Sep 9, 2025
Contributor
|
/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it. |
Contributor
Author
|
@zhanglei1949 could you help merge this PR? |
Member
|
@songqing Could you run the failed checks? |
Contributor
Author
@zhanglei1949 hi master, the failed UT before seems have nothing to do with my PR, and I rebase my PR now, please help trigger the check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When run this WCC algorithm with only one worker, the algorithm will only compute one iteration, so as to cause wrong result.
Fix by add ForceContinue() in PEval() when needed.