Skip to content

[AAASM-4632] 🐛 fix(website): Add missing website/ segment to generated editUrl#282

Merged
Chisanan232 merged 2 commits into
masterfrom
v0.0.1/AAASM-4632/fix/editurl_website_segment
Jul 15, 2026
Merged

[AAASM-4632] 🐛 fix(website): Add missing website/ segment to generated editUrl#282
Chisanan232 merged 2 commits into
masterfrom
v0.0.1/AAASM-4632/fix/editurl_website_segment

Conversation

@Chisanan232

Copy link
Copy Markdown
Contributor

Summary

Every doc page's generated "Edit this page" GitHub link 404'd — editUrl in website/docusaurus.config.ts pointed at the bare repo root, but this Docusaurus site's docs source actually lives under website/. Appended the missing website/ segment.

Test plan

  • curl -sI confirms .../tree/master/website/docusaurus.config.ts → 200, old bare-root form → 404
  • Confirmed only one editUrl occurrence in the file (no separate per-version override needed)
  • Edited file validated via esbuild --bundle=false — parses clean, no errors introduced

Closes AAASM-4632

Every page's "Edit this page" link 404d because editUrl pointed at the
bare repo root, but the Docusaurus site (and its docs source) actually
lives under website/.

Closes AAASM-4632
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Documents end-to-end browser verification of AAASM-4632: the rendered
"Edit this page" link now resolves to the real GitHub source file, with
a before/after contrast screenshot of the old 404ing path.
@sonarqubecloud

Copy link
Copy Markdown

@Chisanan232

Copy link
Copy Markdown
Contributor Author

Claude Code review — AAASM-4632

CI: ✅ All green (CodeQL, SonarCloud, audit, build, coverage-and-analysis, module-smoke x3, napi-build x2, quality, full test matrix across Node 18/20/22/24 × ubuntu/macos/windows, codecov/patch).

Scope completeness: Confirmed complete. Repo-wide grep for editUrl and for the literal bare-root URL string confirms exactly one occurrence existed, and it's the one fixed — no other versioned-docs override, plugin config, README badge, or CONTRIBUTING.md link had the same bug.

Side effects: None found. Checked website/versions.json and every versioned_docs/version-*/ directory's structure — all sit consistently one level under website/, so the single site-wide editUrl config (Docusaurus doesn't require per-version overrides here) is correct for every version, not just current. No _redirects/netlify.toml/vercel.json or other proxy layer sits between the generated link and GitHub. Honest note on CI: CodeQL/SonarCloud/audit pass but don't semantically validate this specific string change — they confirm no build/syntax break, not link correctness; the real behavioral verification is the manual + Playwright check below.

Front-end validation (Playwright MCP): Installed and started the Docusaurus dev server for this worktree (isolated pnpm install --ignore-workspace, Node 24 per engines.node >=22), navigated to the Introduction doc page, and confirmed the rendered "Edit this page" link now includes the website/ segment. Clicked it — landed on the real GitHub file view of the exact source markdown, matching the rendered doc content. Contrast-checked the old bare-root URL directly and confirmed it's a genuine GitHub 404. Full report + screenshots committed to this branch at verification-reports/AAASM-4632.md / verification-reports/AAASM-4632/.

Merge readiness: Technically safe to approve — no scope gaps, no side effects, front-end validated end-to-end. Note: GitHub currently reports mergeable_state: blocked on this PR, but that's due to the repo's branch-protection rule requiring 1 code-owner approval (CODEOWNERS: @Chisanan232 owns *), not a CI or conflict issue — zero reviews exist yet. Merge is blocked only on that required approval.

@Chisanan232 Chisanan232 merged commit 53ec434 into master Jul 15, 2026
27 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-4632/fix/editurl_website_segment branch July 15, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant