Skip to content

Fix typo and rename status to phase#4506

Merged
nikola-jokic merged 1 commit into
masterfrom
revert-4505-revert-4466-nikola-jokic/fix-typo-print-pahse
Jun 15, 2026
Merged

Fix typo and rename status to phase#4506
nikola-jokic merged 1 commit into
masterfrom
revert-4505-revert-4466-nikola-jokic/fix-typo-print-pahse

Conversation

@nikola-jokic

@nikola-jokic nikola-jokic commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Apply #4466

@nikola-jokic nikola-jokic requested a review from mumoshu as a code owner May 22, 2026 10:13
Copilot AI review requested due to automatic review settings May 22, 2026 10:13
@github-actions

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution.

Please review our contribution guidelines to understand the project's testing and code conventions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CRD printer columns to consistently expose .status.phase (and label it “Phase”) across the EphemeralRunner, EphemeralRunnerSet, and AutoscalingRunnerSet APIs, aligning the generated CRDs with the Go type definitions and kubebuilder markers.

Changes:

  • Add a “Phase” printer column for EphemeralRunnerSet CRDs (.status.phase).
  • Rename the EphemeralRunner printer column label from “Status” to “Phase” (still .status.phase).
  • Fix AutoscalingRunnerSet printer column JSONPath from .status.state to .status.phase and rename “State” to “Phase”.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
config/crd/bases/actions.github.com_ephemeralrunnersets.yaml Adds .status.phase additionalPrinterColumn (“Phase”) for EphemeralRunnerSet.
config/crd/bases/actions.github.com_ephemeralrunners.yaml Renames printer column label from “Status” to “Phase” for .status.phase.
config/crd/bases/actions.github.com_autoscalingrunnersets.yaml Switches printer column JSONPath from .status.state to .status.phase and labels it “Phase”.
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml Mirrors EphemeralRunnerSet “Phase” printer column change for the chart CRD.
charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml Mirrors EphemeralRunner “Phase” label change for the chart CRD.
charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml Mirrors AutoscalingRunnerSet .status.phase printer column fix for the chart CRD.
charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunnersets.yaml Mirrors EphemeralRunnerSet “Phase” printer column change for the experimental chart CRD.
charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunners.yaml Mirrors EphemeralRunner “Phase” label change for the experimental chart CRD.
charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_autoscalingrunnersets.yaml Mirrors AutoscalingRunnerSet .status.phase printer column fix for the experimental chart CRD.
apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go Adds kubebuilder printcolumn marker for .status.phase (“Phase”).
apis/actions.github.com/v1alpha1/ephemeralrunner_types.go Renames kubebuilder printcolumn marker label from “Status” to “Phase” for .status.phase.
apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go Updates kubebuilder printcolumn marker from .status.state (“State”) to .status.phase (“Phase”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nikola-jokic nikola-jokic merged commit 9c50514 into master Jun 15, 2026
149 of 159 checks passed
@nikola-jokic nikola-jokic deleted the revert-4505-revert-4466-nikola-jokic/fix-typo-print-pahse branch June 15, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants