fix: require OAuth accounts for Codex models manifest#3998
Open
cyeinfpro wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
503 No available OpenAI OAuth accountsresponse when the group has no eligible manifest accountRoot cause
Requests to
/v1/models?client_version=...are routed toCodexModels. The handler previously used the genericSelectAccountForModel, which can select both OAuth and API Key accounts.FetchCodexModelsManifestthen requires a ChatGPT Codex OAuth access token, so selecting an API Key account produced:{ "error": { "message": "account has no Codex backend access token", "type": "upstream_error" } }In a mixed OAuth/API Key group, repeated model-manifest requests therefore alternated between
200and502depending on the selected account.Validation
go test ./internal/service -run 'Test(SelectCodexModelsAccount|FetchCodexModelsManifest)' -count=1go test ./internal/service ./internal/handler ./internal/server/routes -count=1go vet ./internal/service ./internal/handler ./internal/server/routesgo test ./... -count=1Regression coverage includes:
access_tokenfieldFixes #3995