Connectivity benchmarks: gate larger files#1550
Merged
cmdupuis3 merged 4 commits intoJul 9, 2026
Merged
Conversation
Collaborator
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have improved:
Benchmarks that have stayed the same:
Benchmarks that have got worse:
|
Sevans711
previously requested changes
Jul 9, 2026
Sevans711
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, though I would maybe suggest tiny changes for readability:
- rename
all_paths_existtoall_dyamond_paths_existor something that suggests only glade/dyamond paths are being checked. - (less important) instead of looping with something like:
flag = flag and check, might be more readable to do, e.g.:all(os.path.exists(file_path) for file_path in dyamond_path_dict.values())
Collaborator
Author
|
Maybe, I was trying to mirror what's in the dyamond benchmarks since it's a copy-paste job, so If we change one we should maybe change both. |
Only requested style changes, and those changes deviate from the existing style in other dyamond tests.
Sevans711
approved these changes
Jul 9, 2026
Sevans711
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, my only previous comments were about style, but this style actually matches the existing style from benchmarks/mpas_dyamond.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix an issue with the connectivity benchmarks. The current github runner doesn't seem to have access to the larger dyamond files, so those benchmarks fail and spam up the benchmark logs.
Continuation of #1549.
Overview
I naively copied the file paths from the dyamond benchmarks without the gate, not realizing that the github runner wouldn't have access to them. The gate there basically pings for file access, which will fail for github's runner, but would succeed for someone running somewhere with transparent access to the data on Glade.
PR Checklist
General
Testing
Documentation
_) and have been added todocs/internal_api/index.rstdocs/user_api/index.rstExamples
docs/examples/folderdocs/examples.rsttoctreedocs/gallery.ymlwith appropriate thumbnail photo indocs/_static/thumbnails/