Fix macOS hotkey editor compatibility issues#616
Open
yuygfgg wants to merge 1 commit into
Open
Conversation
Use the native wxDataViewChoiceRenderer for the hotkey command column on macOS, since wxWidgets does not fully support custom data view renderers there. The choice list is populated from the same registered command IDs used by other platforms, so automation commands use the normal command names without any macOS-specific lookup behavior. Also fix a crash when deleting hotkeys on macOS by removing the item from the visible item list before erasing the underlying model object, avoiding a stale wxDataViewItem pointer being queried by NSOutlineView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357
Use the native wxDataViewChoiceRenderer for the hotkey command column on macOS, since wxWidgets does not fully support custom data view renderers there. The choice list is populated from the same registered command IDs used by other platforms, so automation commands use the normal command names without any macOS-specific lookup behavior.
Also fix a crash when deleting hotkeys on macOS by removing the item from the visible item list before erasing the underlying model object, avoiding a stale wxDataViewItem pointer being queried by NSOutlineView.