Skip to content

fix(xl-pdf-exporter): fix emoji rendering for ZWJ sequences in PDF export #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nperez0111 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(xl-pdf-exporter): fix emoji rendering for ZWJ sequences in PDF export #2871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/xl-pdf-exporter/src/pdf/pdfExporter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const PIXELS_PER_POINT = 0.75;
type Options = ExporterOptions & {
/**
*
* @default uses the remote emoji source hosted on cloudflare (https://cdnjs.cloudflare.com/ajax/libs/twemoji/14.0.2/72x72/)
* @default uses Twemoji images from jdecked/twemoji on jsDelivr CDN
*/
emojiSource: false | ReturnType<typeof Font.getEmojiSource>;
};
Expand Down Expand Up @@ -97,8 +97,15 @@ export class PDFExporter<
) {
const defaults = {
emojiSource: {
format: "png",
url: "https://cdnjs.cloudflare.com/ajax/libs/twemoji/14.0.2/72x72/",
builder: (code: string) => {
// Twemoji filenames include fe0f in ZWJ sequences but not in
// standalone emojis, so strip it only when there's no ZWJ (200d).
const resolved = code.includes("200d")
? code
: code.replace(/-fe0f/g, "");
return `https://cdn.jsdelivr.net/gh/jdecked/twemoji@v17.0.3/assets/72x72/${resolved}.png`;
},
withVariationSelectors: true,
},
resolveFileUrl: corsProxyResolveFileUrl,
colors: COLORS_DEFAULT,
Expand Down
Loading