fix(outliner): multi-group concurency on same object#762
Open
Kurtil wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an outline pass issue where outlined tile proxies were keyed only by tile mesh. When the same tile was outlined in multiple groups, one group could overwrite or detach the other, causing non-deterministic outline behavior (see first screen recording where wall items lose their outline).
Root cause
Outlined proxies were stored with a tile-only key, while group operations (update/clean/remove) expected per-group ownership.
Additional context
Before:
BrokenOutline.mov
After:
workingOutline.mov
Note that on this second video, the example is slightly updated to make the select outline group higher priority than the wall outline group.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).