Skip to content

Add go-to / copy current video position to the player slider#11625

Closed
muaz978 wants to merge 1 commit into
SubtitleEdit:mainfrom
muaz978:feature/video-position-goto-copy
Closed

Add go-to / copy current video position to the player slider#11625
muaz978 wants to merge 1 commit into
SubtitleEdit:mainfrom
muaz978:feature/video-position-goto-copy

Conversation

@muaz978

@muaz978 muaz978 commented Jun 14, 2026

Copy link
Copy Markdown

Adds go-to / copy of the current video position, addressing the follow-up on #11598 (@OmrSi: "a way to go to a video position and copy the current video position", which SE4 had on the Video position control).

Right-click the video position slider:

  • Go to video position - opens the existing go-to dialog (previously only reachable via shortcut).
  • Copy - copies the current position as a timecode, applying the configured video offset.

New CopyVideoPosition command; VideoPlayerControl raises GoToPositionRequested/CopyPositionRequested from a context menu on the slider, wired to the view-model in InitVideoPlayer. Reuses existing language strings (no new tags). Builds clean (0/0).

Couldn't GUI-test here; a Windows/macOS test build can be provided to confirm the menu and copy if useful.

@OmrSi

OmrSi commented Jun 14, 2026

Copy link
Copy Markdown
Member

Hey, Muaz.
Maybe it would be better to add the Go to video position to the Go to line number window, allowing the user to have both in one location?

The Go to line number would have to be changed to just Go to… with two items in it, Line Number and Video position, and the name of the shortcut would be changed to Go to line number/video position maybe?

This is how I see it on most platforms, but it's up to @nikolajolsson to decide.

Another option is to add a NumericUpDown with the video position at the bottom in the toolbar, but maybe it wouldn't fit or would look too crowded.

@muaz978

muaz978 commented Jun 15, 2026

Copy link
Copy Markdown
Author

Hey dear,

I can handle both, but let's see what @nikolajolsson say, and then I will act accordingly.

@niksedk

niksedk commented Jun 15, 2026

Copy link
Copy Markdown
Member

We can take a look after v5.0.0 :)

@muaz978

muaz978 commented Jun 15, 2026

Copy link
Copy Markdown
Author

On your mark.

Right-clicking the video position slider now offers "Go to video position"
(the existing ShowGoToVideoPosition dialog) and "Copy" (copies the current
position as a timecode, applying the configured video offset). This restores
the SE4 "Video position" control's ability to jump to and copy the current
position, which had no UI entry point in SE5 - only a shortcut for go-to.

- New CopyVideoPosition command in MainViewModel.
- VideoPlayerControl exposes GoToPositionRequested/CopyPositionRequested events
  via a context menu on the position slider; InitVideoPlayer wires them to the
  view-model commands. Reuses existing language strings (no new tags).
@muaz978 muaz978 force-pushed the feature/video-position-goto-copy branch from eac5c3c to 26a17b1 Compare July 1, 2026 08:44
@muaz978

muaz978 commented Jul 1, 2026

Copy link
Copy Markdown
Author

Rebased this branch onto the latest main. This is purely a sync, no functional changes: it just confirms this stays conflict-free and cleanly mergeable against current main.

@niksedk

niksedk commented Jul 1, 2026

Copy link
Copy Markdown
Member

We already have a "Goto video position" shortcut

@niksedk niksedk closed this Jul 1, 2026
@muaz978 muaz978 deleted the feature/video-position-goto-copy branch July 1, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants