Skip to content

ECHOES-1377 Add icons for Architecture 'system components'#706

Merged
jeremy-davis-sonarsource merged 1 commit into
mainfrom
jay/architecture-icons
Jun 16, 2026
Merged

ECHOES-1377 Add icons for Architecture 'system components'#706
jeremy-davis-sonarsource merged 1 commit into
mainfrom
jay/architecture-icons

Conversation

@jeremy-davis-sonarsource

@jeremy-davis-sonarsource jeremy-davis-sonarsource commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • New components:
    • Added IconComputer, IconDataTable, and IconDatabase to the icon library.
    • Exported the new icon components via the index.ts barrel file.

This will update automatically on new commits.

@netlify

netlify Bot commented Jun 16, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 20a3e21
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a314e75adda8800084e966c
😎 Deploy Preview https://deploy-preview-706--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 16, 2026

Copy link
Copy Markdown

ECHOES-1377

Comment thread src/components/icons/IconComputer.tsx
@gitar-bot

gitar-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds new IconComputer, IconDataTable, and IconDatabase components to the icon library. Please replace the deprecated forwardRef usage in these components with the updated React ref forwarding pattern.

✅ 1 resolved
Quality: New icon components use deprecated forwardRef

📄 src/components/icons/IconComputer.tsx:21 📄 src/components/icons/IconComputer.tsx:24-31 📄 src/components/icons/IconDataTable.tsx 📄 src/components/icons/IconDatabase.tsx
The three new icon components (IconComputer, IconDataTable, IconDatabase) are introduced using forwardRef from React. Per the project's component conventions, forwardRef is deprecated in React 19 (ref is now a regular prop) and should not be used in newly added components — ref should be accepted directly in the props destructuring, e.g. function IconComputer({ ref, ...props }: IconProps).

Note: these new components faithfully follow the established convention used by every existing icon in src/components/icons/ (IconClock, IconComment, IconDashboard, etc.) and the shared IconMaterialWrapper/IconBase wrappers, which all still rely on forwardRef. Because the entire icon family is consistent, this is flagged as a minor migration candidate rather than a blocker — ideally the whole icon set (including the wrapper) migrates away from forwardRef together so the pattern stays uniform.

Suggested fix (applies to each new file):

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@jeremy-davis-sonarsource jeremy-davis-sonarsource enabled auto-merge (squash) June 16, 2026 13:27
@jeremy-davis-sonarsource jeremy-davis-sonarsource merged commit fc75c7e into main Jun 16, 2026
13 checks passed
@jeremy-davis-sonarsource jeremy-davis-sonarsource deleted the jay/architecture-icons branch June 16, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants