ECHOES-1368 Add BadgeCounter Accent variety#702
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Code Review ✅ Approved 1 resolved / 1 findingsIntroduces a new accent variety for the BadgeCounter component with accompanying stories and test coverage. Note that removing forwardRef deviates from the existing component pattern used by sibling badges. ✅ 1 resolved✅ Quality: BadgeCounter diverges from forwardRef pattern used by sibling badges
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
david-cho-lerat-sonarsource
left a comment
There was a problem hiding this comment.
Nice 👍




Part of
Summary by Gitar
BadgeCounterVarietyenum to supportdefaultandaccentvisual styles.varietyprop inBadgeCounterto apply corresponding CSS variables.BadgeCounterto use a standard component function instead offorwardRef.BADGE_COUNTER_VARIETY_STYLESto manage component style variants via CSS variables.Accentstory inBadgeCounter-stories.tsxfor visual verification.BadgeCounter-test.tsxto validate both varieties and accessibility.This will update automatically on new commits.