Improve Hydrogen setup skills and benchmark harness#3801
Closed
fredericoo wants to merge 4 commits into
Closed
Conversation
Port the useful Storefront Kit skill guidance into the renamed Hydrogen v3 skills, including product page setup, query validation, server-only env boundaries, provider-owned variant URL sync, and progressive cart line forms. Stream OpenCode benchmark output incrementally, ignore harness artifacts in workspace change logs, preserve failure summaries, seed Standard Actions runtime assets in the template, and add a documentation dependency map so related docs stay coordinated.
Use the Shopify CDN for Standard Actions in the benchmark template instead of copying vendored runtime files into public. Keep only template-owned public assets and assert the removed Standard Actions, Standard Events, consent, banner, and tools files are not seeded.
Keep the harness test focused on the template contract it still owns: seeding the favicon and loading Standard Actions from the CDN. Avoid asserting that obsolete vendored public files are absent, since the implementation detail is covered by the actual deleted files in the diff.
* feat: add Hydrogen storefront agent skills Add packaged skills and references for building Hydrogen storefronts with agents, including analytics, collection browsing, money formatting, request handlers, Shop Pay, smoke testing, Nuxt wiring, and framework-specific product variant guidance. Update the setup orchestrator and related references so agents can assemble storefront flows from the Hydrogen APIs and examples while keeping environment, cart, analytics, and request-handler responsibilities separated. Co-authored-by: OpenAI Codex <codex@openai.com> * docs: refine Hydrogen storefront skill guidance Tighten the packaged Hydrogen skills so agents follow the source and examples more closely: document storefront route defaults, require gql.tada setup and checks for gql() documents, clarify buyer IP ownership, and use requestContext.applyResponseHeaders directly. Correct Shop Pay guidance for Hydrogen channel, cart checkout mode, and checkoutUrl sourcing; expand money helper output notes; and remove the stale request-handler setup reference now that the standalone skill owns that guidance. Co-authored-by: OpenAI Codex <codex@openai.com> * docs: incorporate RR7 storefront skill feedback Refine the Hydrogen storefront skills based on friction found while creating a React Router 7 storefront with agents. Tighten cart form examples, switch cart drawer guidance to the direct JavaScript dialog path, clarify analytics shop metadata and cart view payloads, and align collection filters, request middleware, gql.tada, and product provider setup with the source and examples. Co-authored-by: OpenAI Codex <codex@openai.com> * docs: incorporate Next storefront skill feedback Refine the Hydrogen storefront skills based on friction found while creating a Next.js storefront with agents. Document module-script loading for Standard Actions, Next proxy naming, analytics Suspense boundaries, canonical env names, and consistent Next storefront client helpers. Tighten collection filter guidance so agents treat Storefront API FilterValue.input as the source of truth and route checkbox params through serializeCollectionParams instead of custom filter mappings. Clarify product add-to-cart and cart mutation form helper boundaries. Co-authored-by: OpenAI Codex <codex@openai.com> --------- Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
An older
storefront-kitPR had useful skill and benchmark-harness hardening that never landed before the package/repo moved into Hydrogen v3.This ports the parts that still make sense after the rename and adapts them to the current Hydrogen APIs, request-scoped client shape, and benchmark environment variable model.
WHAT is this pull request doing?
kit-ownedterminology to Hydrogen-owned terminology and adds a patch changeset for the packaged skill changes..docs/dependencies.mdso future skill, analytics, cart, query-validation, and benchmark changes have an update checklist.HOW to test your changes?
pnpm test:benchmark-harnesspnpm format:checkpnpm lintpnpm --filter @shopify/hydrogen typecheckpnpm --dir packages/hydrogen test src/core/cart src/core/analyticsgit diff --checkLive Docker/OpenCode benchmark note: Docker image build was verified by the verification agent, but the full OpenCode run was not completed because this shell does not have
LLM_API_TOKEN/LLM_API_BASE_URLconfigured.Post-merge steps
None.
Checklist