Cancel WKWebView navigation for externally-opened deep links#292
Open
markmur wants to merge 1 commit into
Open
Cancel WKWebView navigation for externally-opened deep links#292markmur wants to merge 1 commit into
markmur wants to merge 1 commit into
Conversation
React Native — Coverage Report
|
markmur
force-pushed
the
swift-deeplink-cancel
branch
2 times, most recently
from
ef12abd to
00668b5
Compare
markmur
force-pushed
the
swift-deeplink-cancel
branch
from
00668b5 to
73c3d60
Compare
kieran-osgood-shopify
approved these changes
Jun 17, 2026
kieran-osgood-shopify
left a comment
kieran-osgood-shopify
left a comment
Contributor
There was a problem hiding this comment.
Might be worth a call out in our ReadMe too but looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded checkout hands non-HTTP(S) deep links (
tel:,mailto:, app/wallet schemes) to the OS viaUIApplication.shared.open, but then returned.allow, so WKWebView also tried to navigate to a scheme it can't load.That redundant navigation fails - usually a swallowed provisional error that clears the load timer and can blank the current (often offsite payment) page, occasionally a spurious
.sdkErrorsurfaced to the merchant, and on some iOS versions a second app-switch. Since the URL is already delegated to the OS, the success branch now returns.cancel. The open/can-open calls are behind injectable hooks so the branch is unit-testable without firing a real system open.