Skip to content

[MultimediaUtil] Remove deprecated ExtractAsync method#7614

Open
hsgwon wants to merge 2 commits into
Samsung:mainfrom
hsgwon:api14.util.removeAsyncExtract
Open

[MultimediaUtil] Remove deprecated ExtractAsync method#7614
hsgwon wants to merge 2 commits into
Samsung:mainfrom
hsgwon:api14.util.removeAsyncExtract

Conversation

@hsgwon

@hsgwon hsgwon commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description of Change

Remove deprecated ExtractAsync method

API Changes

  • TCSACR-650

@hsgwon hsgwon requested a review from neoiomok May 4, 2026 05:16
@hsgwon hsgwon added ACR Required API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0 labels May 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated ExtractAsync methods and their associated internal logic from the ThumbnailExtractor class. Feedback suggests cleaning up now-unused System.Threading and System.Threading.Tasks namespaces and updating the class-level <since_tizen> tag to version 6 to accurately reflect the supported API version after these removals.

Comment thread src/Tizen.Multimedia.Util/ThumbnailExtractor/ThumbnailExtractor.cs
Comment thread src/Tizen.Multimedia.Util/ThumbnailExtractor/ThumbnailExtractor.cs
@TizenAPI-Bot

Copy link
Copy Markdown
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 4, Changed: 0

Removed

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,System.Threading.CancellationToken)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size,System.Threading.CancellationToken)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String)

@TizenAPI-Bot

Copy link
Copy Markdown
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 4, Changed: 0

Removed

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,System.Threading.CancellationToken)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size,System.Threading.CancellationToken)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String,Tizen.Multimedia.Size)

- /// <since_tizen>4</since_tizen
- [Obsolete]
- static System.Threading.Tasks.Task`1<Tizen.Multimedia.Util.ThumbnailExtractionResult> Tizen.Multimedia.Util.ThumbnailExtractor::ExtractAsync(System.String)

@JoonghyunCho

Copy link
Copy Markdown
Member

🤖 [AI Review]

Reviewed — no findings.

Scope checked:

  • All 170 deleted lines are 4 [Obsolete]-marked ExtractAsync overloads plus their two private helpers (RunExtractAsync, ExtractAsyncCore) that were exclusively callers of the obsolete methods.
  • Verified via repo-wide search that no remaining call sites reference ExtractAsync outside the modified file — removal is safe.
  • The Obsolete message stated removal in API12; this PR removes them at API14 (label API14), backed by ACR TCSACR-650.
  • Public surviving Extract overloads in the same class are unchanged in signature.
  • No new public APIs introduced, so no XML-doc / since_tizen requirements apply.

No 🔴 critical issues, no 🟡 suggestions to flag.


Automated review — final merge decision rests with human reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACR Required API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants