buildsystem: drop source __pycache__ dirs in mrproper#1803
Merged
Conversation
make mrproper left every __pycache__/ in the source tree behind: the clean targets only run against the out-of-source build dir, but running python from the repo (tests, codegen, the converter) scatters bytecode caches through openage/ and buildsystem/. cleaninsourcebuild now removes those too, outside .bin, matching the other in-source cleanups already there. Closes SFTtech#442.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
make checkmergemake mrproperleft every__pycache__/in the source tree behind. The clean targets only run against the out-of-source build dir, but running python from the repo (tests, codegen, the converter) scatters bytecode caches throughopenage/andbuildsystem/and nothing swept those up.cleaninsourcebuildnow removes them too, outside.bin, alongside the other in-source cleanups it already does.Checked on a built tree: 46
__pycache__dirs before,git clean -ndxclean aftermake mrproper.Closes #442.