Fix level requirements on staves, wands, and jewellery and unique items#2323
Merged
Merged
Conversation
Blitz54
changed the title
added 6 commits
July 8, 2026 18:48
The unique export now has a number of fixes and additions It now inherits the implicit mods from a item base and include skill mods in the implicit count without having to specifically state it It correctly orders implicit mods now which was not done before Bases that grant skills now use the correct level range e.g Raise Shield now doesn't show the level range of 1-20 Belt bases now have the correct implicit mods and exclude the charm mod if the base already grants it Level requirements for gear now only print the value if it exceeds the base type Many uniques have had their unique mod IDs updated to use the correct ones so the required level is correct
Uniques not grab their base level from the unique in the db so that if they are modified by runes they can fall back to the correct level if the rune is removed Fixed the level requirement for Runic Fork as it wasn't being exported as it didn't have a skill Fix the export of uniques with legacy implicits not having the correct Implicit count Fix Wondertrap export typo Clean up uModsToText script Adds tests for new scenarios
LocalIdentity
changed the title
LocalIdentity
approved these changes
Jul 10, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
Will need to update that code once we move to using mod IDs as it will simplify all this a bunch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
0.5.4 changed granted skills, so that the item does not require level or attributes for the granted skill. The requirements are either from the base item, or specifically for the unique (Sylvan's Effigy level 62 on a Stoic Sceptre which is level 6).