Skip to content

test: keep asset lock batch mempool sync#48

Open
thepastaclaw wants to merge 1 commit into
PastaPastaPasta:codex/fix-feature-asset-locks-flakefrom
thepastaclaw:pr7411-knst-sync
Open

test: keep asset lock batch mempool sync#48
thepastaclaw wants to merge 1 commit into
PastaPastaPasta:codex/fix-feature-asset-locks-flakefrom
thepastaclaw:pr7411-knst-sync

Conversation

@thepastaclaw

Copy link
Copy Markdown

PR 7411 Review Follow-Up

Issue Being Fixed Or Feature Implemented

Follow-up for knst's review feedback on dashpay#7411:
dashpay#7411 (comment)

What Was Done

Reverted the asset-lock reorg padding change back to generate_batch(25) and
removed the now-unused generate_batch(sync_fun=...) plumbing.

How Has This Been Tested

  • git diff --check
  • python3 -m py_compile test/functional/feature_asset_locks.py
python3 test/functional/feature_asset_locks.py \
  --configfile=/Users/claw/Projects/dash/test/config.ini \
  --tmpdir=/private/tmp/dash_pr7411_knst_sync \
  --portseed=7411 \
  --timeout-factor=4

Breaking Changes

None.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b8160a85-20c2-435b-b5a0-8831a7ec2608

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant