fix(ci): use test-safety runner for DCU tests#79324
Conversation
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-06-16 21:23:06
📋 Review 摘要
PR 概述:将 Linux-DCU Test job 的 runner group 从 dcu-z100 切到 test-safety,同时额外改动了 python/paddle/batch.py。
变更范围:GitHub Actions DCU CI、Python 顶层 API 模块
影响面 Tag:[Execute Infrastructure] [User Experience]
问题
| 级别 | 文件 | 概述 |
|---|---|---|
| 🟡 建议 | python/paddle/batch.py:86 |
CI runner PR 中混入无关联的 no-op __docformat__ 函数 |
历史 Findings 修复情况
| Finding | 问题 | 状态 |
|---|---|---|
| F1 | test-safety runner group 是否保证只包含可运行 DCU 测试的 runner? |
📝 PR 规范检查
PR 标题使用 fix(ci): ...,不符合 Paddle 要求的 [Tag] 标题描述 格式;PR 描述也缺少 develop 分支必填的 ### PR Category、### PR Types、### Description、### 是否引起精度变化 四个 section。
标题建议(可直接复制):
[Execute Infrastructure] Use test-safety runner for DCU tests
PR 描述建议(点击展开,可直接复制)
### PR Category
<!-- One of [ User Experience | Execute Infrastructure | Operator Mechanism | CINN | Custom Device | Performance Optimization | Distributed Strategy | Parameter Server | Communication Library | Auto Parallel | Inference | Environment Adaptation ] -->
Execute Infrastructure
### PR Types
<!-- One of [ New features | Bug fixes | Improvements | Performance | BC Breaking | Deprecations | Docs | Devs | Not User Facing | Security | Others ] -->
Bug fixes
### Description
<!-- Describe what you’ve done -->
Use the `test-safety` runner group for the Linux-DCU `Test` job in `.github/workflows/_Linux-DCU.yml`, replacing the previous `dcu-z100` runner group. Impact scope: DCU test job scheduling only. Validation: N/A.
### 是否引起精度变化
<!-- one of the following [ 是 | 否 ]-->
否总体评价
Workflow 变更本身只触及 DCU test job 调度;历史 runner group 覆盖问题仍缺少代码侧证据证明已解决。本轮新增的 Python 源码改动与 CI 目标不一致,建议移出本 PR 后再合入。
|
|
||
| return batch_reader | ||
|
|
||
| def __docformat__(**kwargs): |
There was a problem hiding this comment.
🟡 建议 这个新增的 __docformat__ 函数与本 PR 的 DCU runner 调整无关,而且当前模块只通过 python/paddle/__init__.py 手工导出 batch,batch.py 自身的 __all__ 为空。
__docformat__ 通常是模块文档元数据名,这里新增一个 no-op callable 不会参与 paddle.batch 的行为修复,只会让 Python 源码变更混入 CI 配置 PR,增加 API/文档工具误判的风险。
建议修复方式:从本 PR 中移除这两行,只保留 .github/workflows/_Linux-DCU.yml 的 runner group 变更;如果确实需要修改 batch.py,请单独说明目的并补充对应验证。
CI报告基于以下代码生成(30分钟更新一次): 1 Required任务 : 16/30 通过
2 失败详情🔴 Check PR Template / Check — PR问题:PR模板字段不合规(置信度: 高)分析器: 通用分析(fallback) 失败用例:
关键日志:
修复建议:
关联变更: PR 描述;代码变更为 🔴 Codestyle-Check / Pre Commit — PR问题:格式化钩子修改文件(置信度: 高)分析器: 通用分析(fallback) 失败用例:
关键日志:
修复建议:
关联变更: |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #79324 +/- ##
==========================================
Coverage ? 50.00%
==========================================
Files ? 1
Lines ? 2
Branches ? 0
==========================================
Hits ? 1
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Use the test-safety runner group for DCU tests.