Skip to content

fix: point android-dts-generator submodule at main#1975

Open
adrian-niculescu wants to merge 1 commit into
NativeScript:mainfrom
adrian-niculescu:fix/dts-generator-submodule-branch
Open

fix: point android-dts-generator submodule at main#1975
adrian-niculescu wants to merge 1 commit into
NativeScript:mainfrom
adrian-niculescu:fix/dts-generator-submodule-branch

Conversation

@adrian-niculescu

@adrian-niculescu adrian-niculescu commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The android-dts-generator submodule tracks branch = master in .gitmodules, but that repo renamed its default branch to main and deleted master. git ls-remote https://github.com/NativeScript/android-dts-generator.git only lists main now.

A normal recursive clone isn't affected, since it checks out the recorded commit and ignores the branch field, and that commit is reachable. What does break is git submodule update --remote, which tries to resolve origin/master and finds nothing there. This just points the submodule at the branch that actually exists.

Summary by CodeRabbit

  • Chores
    • Updated Android build tools repository configuration to track the latest development branch.

The android-dts-generator repo renamed its default branch from master
to main and deleted master, so the submodule's `branch = master` no
longer resolves and `git submodule update --remote` fails to find it.
Point it at the branch that actually exists.
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 87666b20-d0a7-4bc8-b54a-28bcaf6e49d7

📥 Commits

Reviewing files that changed from the base of the PR and between a84d3c7 and db3ff2e.

📒 Files selected for processing (1)
  • .gitmodules

📝 Walkthrough

Walkthrough

This PR updates the .gitmodules configuration to direct the test-app/build-tools/android-dts-generator submodule to track the main branch instead of master, aligning with the current primary branch naming convention.

Changes

Submodule Configuration Update

Layer / File(s) Summary
Submodule branch configuration
.gitmodules
The branch tracking setting for the android-dts-generator submodule is changed from master to main.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A branch renamed from old to new,
Main takes the lead, as repos do,
One line, one change, a simple beat,
The submodule's path is now complete!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the android-dts-generator submodule to track the main branch instead of master.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant