fix: point android-dts-generator submodule at main#1975
fix: point android-dts-generator submodule at main#1975adrian-niculescu wants to merge 1 commit into
Conversation
The android-dts-generator repo renamed its default branch from master to main and deleted master, so the submodule's `branch = master` no longer resolves and `git submodule update --remote` fails to find it. Point it at the branch that actually exists.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the ChangesSubmodule Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The
android-dts-generatorsubmodule tracksbranch = masterin.gitmodules, but that repo renamed its default branch tomainand deletedmaster.git ls-remote https://github.com/NativeScript/android-dts-generator.gitonly listsmainnow.A normal recursive clone isn't affected, since it checks out the recorded commit and ignores the branch field, and that commit is reachable. What does break is
git submodule update --remote, which tries to resolveorigin/masterand finds nothing there. This just points the submodule at the branch that actually exists.Summary by CodeRabbit