Build cuda.core RDC test fixtures without Bash#2335
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
lijinf2
reviewed
Jul 9, 2026
lijinf2
approved these changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
Thanks for clarifying. I’m okay with keeping the current approach: bare nvcc from PATH, narrow skip classification for known host compilers, and fail visibly for unknown nvcc failures and log message updates.
One minor suggestion: please consider adding a short code comment/doc note that this test intentionally assumes nvcc is on PATH and a working host compiler environment is configured.
Contributor
Author
|
Member
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
cuda.coreRDC test fixture build from a Bash script to a small Python driver aroundnvcc.Why this change:
nvcc, but they no longer require Bash. That avoids Windows-specific ambiguity between Git Bash, WSL Bash, path conversion behavior, and environment propagation.nvccdirectly from Python withsubprocess, using the platform's normalPATHlookup.nvccto be onPATHis straightforward, matches normal CUDA command-line expectations, and avoids passing a fullnvccpath through another layer.nvccbeing unavailable, the host compiler environment being unavailable, and othernvccfailures. Only the first two become skips; unexpectednvccfailures still fail the test.Suggested review path:
cuda_core/tests/test_binaries/build_test_binaries.pyfirst. It is the Python replacement for the deleted Bash script._build_saxpy_rdc()incuda_core/tests/test_module.pynext. That is where the local fallback behavior and skip/fail policy lives.nvcc --versionto aid troubleshooting and then the Python fixture builder.