[None][test] Increase timeout for Kimi-K2.5 disaggregated nvfp4 test#15970
Merged
Shixiaowei02 merged 1 commit intoJul 6, 2026
Merged
Conversation
The test-list override TIMEOUT (90) capped TestKimiK25::test_nvfp4 at 90 minutes, overriding the class-level @pytest.mark.timeout(10800). Kimi-K2.5 (~1T-param NVFP4) is loaded across two disaggregated servers (ctx TP4 + gen TP4); weight loading alone is ~37 min per server, so both servers only reached startup-complete right as the 90-min budget expired, before the GSM8K accuracy eval could run. Raise the override to 180 minutes to match the class decorator and the gb200 Kimi entries. Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
996283b to
f5fad3c
Compare
Collaborator
Author
|
/bot skip --comment "timeout value modification only" |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the timeout for the ChangesTest timeout update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
PR_Github #57742 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #57742 [ skip ] completed with state |
chuangz0
approved these changes
Jul 6, 2026
BrianLi23
pushed a commit
to BrianLi23/TensorRT-LLM
that referenced
this pull request
Jul 9, 2026
…VIDIA#15970) Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the test configuration by increasing the timeout for a specific test case. The timeout for
TestKimiK25::test_nvfp4inaccuracy/test_disaggregated_serving.pyhas been increased from 90 seconds to 180 seconds to accommodate longer test runtimes.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Summary by CodeRabbit