[TRTLLM-13600][test] Clean up Qwen3 test cases#15591
Conversation
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughAccuracy tests for Qwen3-8B, Qwen3-30B-A3B, and Qwen3-235B-A22B are updated to remove ChangesQwen3 accuracy test parametrization and CUDA graph config standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/defs/accuracy/test_llm_api_pytorch.py`:
- Around line 4397-4412: `test_fp8_block_scales` no longer exercises the
CUDA-graph path because `cuda_graph` is effectively fixed to `False`, so the
`CudaGraphConfig` branch is dead. Update `test_fp8_block_scales` in
`test_llm_api_pytorch.py` to either restore a parameterized CUDA-graph case that
actually instantiates `CudaGraphConfig` or remove
`cuda_graph`/`cuda_graph_config` from the test and rename the test to reflect
its real coverage, keeping the `LLM` setup and `pytorch_config` aligned with the
intended behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cd816e26-864d-41e2-b49c-6fbfe0f5e492
📒 Files selected for processing (5)
tests/integration/defs/accuracy/test_llm_api_pytorch.pytests/integration/test_lists/test-db/l0_b200.ymltests/integration/test_lists/test-db/l0_dgx_b200.ymltests/integration/test_lists/test-db/l0_dgx_b300.ymltests/integration/test_lists/test-db/l0_h100.yml
|
PR_Github #55491 [ run ] triggered by Bot. Commit: |
|
PR_Github #55492 [ run ] triggered by Bot. Commit: |
|
PR_Github #55492 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55648 [ run ] triggered by Bot. Commit: |
|
PR_Github #55648 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #55724 [ run ] triggered by Bot. Commit: |
|
PR_Github #55724 [ run ] completed with state |
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.