Skip to content

[https://nvbugs/6344108][fix] skip TestNemotron3Super120B on pre-blackwell#15539

Open
bo-nv wants to merge 1 commit into
NVIDIA:mainfrom
bo-nv:main-6344108
Open

[https://nvbugs/6344108][fix] skip TestNemotron3Super120B on pre-blackwell#15539
bo-nv wants to merge 1 commit into
NVIDIA:mainfrom
bo-nv:main-6344108

Conversation

@bo-nv

@bo-nv bo-nv commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

…kwell

Summary by CodeRabbit

  • Tests
    • Updated test configuration for improved compatibility with hardware conditions.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…kwell

Signed-off-by: Bo Deng <deemod@nvidia.com>
@bo-nv bo-nv requested a review from a team as a code owner June 23, 2026 09:21
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 94535ede-133d-468a-8e24-4b8bf042d2e0

📥 Commits

Reviewing files that changed from the base of the PR and between 31d4301 and e19d10f.

📒 Files selected for processing (1)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py

📝 Walkthrough

Walkthrough

A single @skip_pre_blackwell decorator is added to the TestNemotron3Super120B test class in the disaggregated serving accuracy test module, causing the class to be skipped on pre-Blackwell hardware in addition to existing timeout and device-memory guards.

Changes

Skip TestNemotron3Super120B on pre-Blackwell

Layer / File(s) Summary
Add @skip_pre_blackwell decorator
tests/integration/defs/accuracy/test_disaggregated_serving.py
Inserts @skip_pre_blackwell into the decorator stack of TestNemotron3Super120B, joining the existing @pytest.mark.timeout and @pytest.mark.skip_less_device_memory(80000) decorators.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, containing only template boilerplate with all required sections (Description, Test Coverage) left blank and unchecked checklist items. Fill in the Description section explaining the issue and solution, list relevant test coverage for the skip marker change, and review/check appropriate PR checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a skip marker for TestNemotron3Super120B on pre-blackwell hardware, matching the changeset exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants