Skip to content

[None][CI] Waive flaky test_vbench_dimension_score_wan (nvbugs/6357628)#15529

Open
chang-l wants to merge 1 commit into
NVIDIA:mainfrom
chang-l:fix/waive-vbench-wan-flaky
Open

[None][CI] Waive flaky test_vbench_dimension_score_wan (nvbugs/6357628)#15529
chang-l wants to merge 1 commit into
NVIDIA:mainfrom
chang-l:fix/waive-vbench-wan-flaky

Conversation

@chang-l

@chang-l chang-l commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

What

Waive the flaky test examples/visual_gen/test_visual_gen.py::test_vbench_dimension_score_wan (SKIP), tracked by nvbugs/6357628.

Why

The test is flaky by design: it generates a video with a non-deterministic seed (VisualGenParams.seed defaults to None) and compares absolute per-dimension VBench scores against a single fixed-seed HF-reference golden with a uniform 0.05 band. Several dimensions vary far more than 0.05 across seeds — dynamic_degree is effectively binary (0/1), and aesthetic_quality/imaging_quality swing 0.15–0.25.

Reproduced on upstream/main HEAD (B200, exact CI config: 4 GPU, cfg_size=2, ulysses_size=1, full 6-dimension VBench), three identical-config runs → FAIL / PASS / FAIL, each failing on a different dimension. Single-GPU and 2-GPU both pass at a fixed seed, so this is not a code regression (suspect commits #13978 / #14961 / #14687 ruled out).

This mirrors the already-waived sibling tests test_vbench_dimension_score_wan22_a14b_fp8 / _nvfp4 (nvbugs/6310230).

Recommended real fix (for visual_gen owners @NVIDIA/trt-llm-torch-visual-gen-devs)

Pin a fixed generation seed (verified deterministic), re-baseline all 6 goldens from pinned-seed runs, and special-case the binary dynamic_degree (exact match, not a 0.05 band). Tracked in nvbugs/6357628.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Added test skip entry for a known issue in visual generation testing.

VBench per-dimension scores (subject_consistency, aesthetic_quality,
dynamic_degree) vary far more than the test's 0.05 band across its
non-deterministic generation seed (dynamic_degree is binary 0/1), so the
test fails intermittently on different dimensions. Reproduced FAIL/PASS/FAIL
across three identical 4-GPU runs at upstream/main HEAD; not a code
regression. Tracked by nvbugs/6357628.

Signed-off-by: Chang Liu <liuc@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a3d49441-d5f2-41aa-bad1-070d93931132

📥 Commits

Reviewing files that changed from the base of the PR and between 9ed7ce4 and 4100b21.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A single SKIP waiver entry for examples/visual_gen/test_visual_gen.py::test_vbench_dimension_score_wan is appended to tests/integration/test_lists/waives.txt, referencing bug tracker link https://nvbugs/6357628.

Changes

Test Waiver Addition

Layer / File(s) Summary
SKIP waiver entry
tests/integration/test_lists/waives.txt
Inserts one new line marking test_vbench_dimension_score_wan as SKIP with a reference to nvbugs/6357628.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: waiving a flaky test with the associated bug tracking ID.
Description check ✅ Passed The PR description provides comprehensive context including what is being changed, why (detailed explanation of flakiness with reproducible evidence), and recommendations for permanent fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant