fix(models): temporarily disable TE fused RoPE globally#3028
Merged
Conversation
Force rope_fusion=False in BackendConfig.__post_init__ so no model family uses TE's fused RoPE kernel. The fused kernel computes cos/sin in fp32 in-kernel while HF/vLLM rotate with bf16 tables, breaking logprob parity in some models. Temporary workaround; see #3027. Signed-off-by: HuiyingLi <willwin.lee@gmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Add TestBackendConfigRopeFusionDisabled: default resolves False, explicit True is overridden (with warning), explicit False stays False. See #3027. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test cbcaeeb |
Contributor
Author
|
/claude review |
akoumpa
reviewed
Jul 11, 2026
akoumpa
reviewed
Jul 11, 2026
Contributor
|
/ok to test 958cedc |
akoumpa
previously approved these changes
Jul 11, 2026
The qwen3_moe / deepseek_v3 context-parallel thd_te tests built RoPE frequencies with for_fused_rope=True while relying on the default BackendConfig.rope_fusion. With fused RoPE now force-disabled globally (see #3027), the attention takes the non-fused path but the fused-format freqs no longer match -> thd_te parity check fails. Derive for_fused_rope from the resolved backend.rope_fusion so freqs and attention stay consistent; this exercises the non-fused CP path that production already uses for cp_size>1, and auto-restores to fused when #3027 is reverted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Contributor
Author
|
/ok to test f2197b8 |
akoumpa
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Force
rope_fusion=Falsefor everyBackendConfigin__post_init__, disabling TE fused RoPE globally.Why
The fused RoPE kernel computes cos/sin in fp32 in-kernel while HF/vLLM rotate with bf16 tables, breaking logprob parity in some models (e.g. Qwen3-MoE). Temporary correctness-over-speed workaround until a parity fix lands — see #3027.
Notes
rope_fusion: truein a recipe/config; logs a one-time rank-0 warning when overriding an explicitTrue.BackendConfig.__post_init__.🤖 Generated with Claude Code