fix(retrieval): preserve bi-encoder export metadata#2905
Draft
oliverholworthy wants to merge 1 commit into
Draft
fix(retrieval): preserve bi-encoder export metadata#2905oliverholworthy wants to merge 1 commit into
oliverholworthy wants to merge 1 commit into
Conversation
Signed-off-by: Oliver Holworthy <1216955+oliverholworthy@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves bi-encoder wrapper settings in consolidated exports and restores them when the export is loaded again.
Changelog
config.jsonor the AutoModel v5 sidecar while preserving explicit loader overrides.Before your PR is "Ready for review"
Pre checks:
Validation
uv run ruff format <changed files>uv run ruff check --fix <changed files>uv run pytest tests/unit_tests/_transformers/test_registry.py tests/unit_tests/_transformers/test_retrieval.py tests/unit_tests/models/bi_encoder/test_llama_bidirectional_model.py -q(63 passed)uv run python examples/retrieval/data_utils/export_biencoder_with_metadata.py --helpAdditional Information
Extracted from #2306 so that the fine-tuning documentation PR does not carry model-loading behavior.