Fix GitHub Pages deploy and harden CI workflows#18
Merged
Conversation
The Pages build was failing because actions/upload-pages-artifact@v1 transitively depends on the now-deprecated actions/upload-artifact@v3, which GitHub hard-fails. - Bump all actions to their latest releases (fixes the deprecated artifact failure on upload-pages-artifact and deploy-pages) - Pin every action to a full commit SHA with a version comment so a tampered/repointed tag cannot reach CI (supply-chain hardening) - Use pnpm install --frozen-lockfile so CI fails on lockfile drift instead of silently resolving new versions - Build with pnpm exec (locked Nuxt from node_modules) instead of pnpm dlx, which fetched a fresh, unpinned Nuxt from the registry
Deploying web with
|
| Latest commit: |
04db9d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://397f98a5.web-9b9.pages.dev |
| Branch Preview URL: | https://fix-github-pages-deploy.web-9b9.pages.dev |
Insprill
approved these changes
Jul 1, 2026
4everTheOne
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The GitHub Pages mirror build was failing because
actions/upload-pages-artifact@v1transitively depends on the now-deprecated
actions/upload-artifact@v3, whichGitHub hard-fails. This fixes that and hardens both workflows.
Changes
failure on
upload-pages-artifactanddeploy-pages.# vX.Y.Zcomment) so atampered or repointed tag cannot reach CI — supply-chain hardening.
pnpm install --frozen-lockfilein both workflows, so CI fails on lockfiledrift instead of silently resolving new versions.
pnpm exec(locked Nuxt fromnode_modules) instead ofpnpm dlx, which fetched a fresh, unpinned Nuxt from the registry.Verification
pnpm install --frozen-lockfileconfirmed to pass against the committedlockfile locally (no pre-existing drift, so this won't red-X the first run).
Follow-up (not in this PR)
Nothing currently bumps the new SHA pins (no Renovate config in the repo; Snyk
only covers app deps). Consider adding a
.github/dependabot.ymlfor thegithub-actionsecosystem to keep the digests patched.