fix(electron): map IPv6 :: wildcard to localhost#4188
Merged
KristjanESPERANTO merged 1 commit intoJun 20, 2026
Merged
Conversation
When config.address is set to "::" (listen on all interfaces), the Electron window tries to load http://:::8080 instead of http://localhost:8080, resulting in a blank local display. The remap that converts wildcard bind addresses to "localhost" for the Electron loadURL call already handled undefined, "", and "0.0.0.0", but was missing "::". Add it.
KristjanESPERANTO
changed the title
KristjanESPERANTO
approved these changes
Jun 20, 2026
Collaborator
|
@MikeBishop Thanks! With IPv6 becoming more widespread, this is a valuable improvement 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
config.addressis set to"::"(listen on all interfaces), the Electron window tries to loadhttp://:::8080instead ofhttp://localhost:8080, resulting in a blank local display.Root cause
electron.jsremaps wildcard bind addresses to"localhost"for the ElectronloadURLcall so the local display always connects to the server on the loopback interface. This remap already handledundefined,"", and"0.0.0.0", but"::"was missing.Note:
core.start()is not affected — at the time that check runs,configis initialised fromprocess.env.config(empty{}in normal operation), soconfig.addressis alwaysundefinedand the server always starts correctly.Fix
One line: add
(config.address === "::")to the existing wildcard remap increateWindow().