fix(examples): remove unused vtk-root element#3543
Conversation
finetjul
left a comment
There was a problem hiding this comment.
Can you please explain what the problem is/was ?
I don't know why this fixes the problem. As explained in the top comment, I noticed the example's content was present in the page, but under a blank div. I searched for a working example with a similar structure (one that uses document.createElement), which is DepthTest, and tested it. |
|
@Jo-Byr just remove the div with id "vtk-root" it was not used https://github.com/Kitware/vtk-js/blob/master/Documentation/scripts/build-examples.mjs#L66 |
eb0e1e7 to
190858a
Compare
Remove unused vtk-root element from generated examples HTML
190858a to
20dbb96
Compare
finetjul
left a comment
There was a problem hiding this comment.
LGTM.
Please edit your PR opening comment.
|
🎉 This PR is included in version 36.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
Some examples have been broken since the switch to lil-gui, the example of ResliceCursorWidget is one of them. The widgets were displayed below a white div.
Results
The example is now correctly displayed.
Changes
Added a container element, by taking inspiration from DepthTest example.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting
Tested with