COMP: Audit — disable all CTest warning suppressions to surface hidden warnings#461
Draft
hjmjohnson wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
type:Compiler
Comment out every CTEST_CUSTOM_WARNING_EXCEPTION and CTEST_CUSTOM_ERROR_EXCEPTION pattern so CI surfaces the warnings each suppression was masking. This is a diagnostic pass to decide which suppressions are still needed versus which hide real, fixable warnings. The set() scaffolding is preserved so the configured CTestCustom.cmake remains valid with an empty exception list. Suppressions will be restored selectively after reviewing the CDash output.
hjmjohnson
force-pushed
the
audit/uncomment-ctest-warning-suppressions
branch
from
5d8bd42 to
a7af65e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic PR: temporarily comments out every
CTEST_CUSTOM_WARNING_EXCEPTION/CTEST_CUSTOM_ERROR_EXCEPTIONpattern inCMake/CTestCustom.cmake.inso CI surfaces the warnings each suppression was hiding. Not intended to merge as-is — the goal is to read the CDash output and then restore only the suppressions that are still warranted.Follow-up to the suppression-audit note on #449 (
CTestCustom.cmake.in— "we should review all the suppressions and re-evaluate whether they are needed").What to look at in CI
Modules/ThirdParty/..., vnl, OpenCV, Sphinx deprecations, etc.).CTEST_CUSTOM_MAXIMUM_NUMBER_OF_WARNINGSis still 199, so CDash truncates the list at 199 — the count is a floor, not the true total.set()scaffolding and${VAR}continuation lines are preserved, so the configuredCTestCustom.cmakestays valid with an empty exception list.Next steps