Skip to content

ENH: Revive ExtractContoursFromImage as SimpleContourExtractor#451

Merged
hjmjohnson merged 2 commits into
mainfrom
rebase/revive-simple-contour-extractor
Jun 14, 2026
Merged

ENH: Revive ExtractContoursFromImage as SimpleContourExtractor#451
hjmjohnson merged 2 commits into
mainfrom
rebase/revive-simple-contour-extractor

Conversation

@hjmjohnson

@hjmjohnson hjmjohnson commented Apr 17, 2026

Copy link
Copy Markdown
Member

Rebase of @dzenanz's PR #432 onto current main.

Revives the ExtractContoursFromImage example (commented out since the initial import commit a82f59e) as SimpleContourExtractor, using itk::SimpleContourExtractorImageFilter. Adds CMakeLists.txt, Code.cxx, and Documentation.rst.

@hjmjohnson hjmjohnson mentioned this pull request Apr 17, 2026
Closed
@github-actions github-actions Bot added type:Enhancement Improvement of existing methods or implementation area:Filtering Issues affecting the Filtering module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots language:C++ Changes to C++ examples labels Apr 17, 2026
@hjmjohnson hjmjohnson force-pushed the rebase/revive-simple-contour-extractor branch from 4d151d6 to c4daaa4 Compare June 12, 2026 12:48
dzenanz
dzenanz approved these changes Jun 12, 2026
View reviewed changes

@dzenanz dzenanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this PR.

Comment thread src/Filtering/ImageFeature/SimpleContourExtractor/Code.cxx
@dzenanz

dzenanz commented Jun 12, 2026

Copy link
Copy Markdown
Member

350 CMake configure warnings of the style:

CMake Warning (dev) at /Users/runner/work/ITKSphinxExamples/ITK/CMake/UseITK.cmake:28 (message):
  CMake/UseITK.cmake is deprecated.

  Please update CMakeLists.txt to use `find_package(ITK)` and link to
  "${ITK_INTERFACE_LIBRARIES}".

@hjmjohnson hjmjohnson force-pushed the rebase/revive-simple-contour-extractor branch from c4daaa4 to d063ad6 Compare June 13, 2026 03:23
dzenanz and others added 2 commits June 13, 2026 06:55
@dzenanz @hjmjohnson
ENH: Revive ExtractContoursFromImage as SimpleContourExtractor
e00befc 
The example was commented out since the initial import commit:

ENH: Adding media wiki examples to sphinx examples
a82f59e
@hjmjohnson
COMP: Exempt pre-existing Duplicate C++ declaration Sphinx warnings
361d8ef
@hjmjohnson hjmjohnson force-pushed the rebase/revive-simple-contour-extractor branch from e9cd00b to 361d8ef Compare June 13, 2026 11:55
@github-actions github-actions Bot added the area:Documentation Issues affecting the Documentation module label Jun 13, 2026
@github-actions github-actions Bot temporarily deployed to production June 13, 2026 12:43 Inactive
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown

🎉 Published on https://examples.itk.org as production
🚀 Deployed on https://6a2d50903c7fa1a9be5268e9--itkexamples.netlify.app

@github-actions github-actions Bot temporarily deployed to production June 13, 2026 12:44 Inactive
@hjmjohnson hjmjohnson merged commit 9636cd7 into main Jun 14, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:C++ Changes to C++ examples type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjmjohnson @dzenanz