fix(subheader): prevent scroll jump when opening igc-select#83
Open
dobromirts wants to merge 1 commit into
Open
fix(subheader): prevent scroll jump when opening igc-select#83dobromirts wants to merge 1 commit into
dobromirts wants to merge 1 commit into
Conversation
Member
|
Regarding point 2, that should be logged as an issue in the select component itself and fixed there IMO. Also, since we depend on igniteui-webcomponents, can we use Lit to encapsulate all the vanilla JS stuff around some of the astro components into a bunch of custom elements (that is no Shadow DOM), just to make easier to template, bind and keep up state more structured. Feel free to ping me for additional discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81
Clicking the package/version igc-select in the sticky subheader while scrolled down caused the page to jump.