chore: Add btp cli shell completion for bash, pwsh and zsh#269367
Open
paulchen5 wants to merge 1 commit into
Open
chore: Add btp cli shell completion for bash, pwsh and zsh#269367paulchen5 wants to merge 1 commit into
bash, pwsh and zsh#269367paulchen5 wants to merge 1 commit into
Conversation
Author
|
When running ### Begin SAP BTP command line interface autocomplete
eval "$(btp --autocomplete=init:zsh)"
### End SAP BTP command line interface autocomplete |
Author
|
Is there a way to check that it works locally? |
Author
|
Well I think I was mixing up casks here with formulas. Is there a reason why the cli tool is being counted as a cask? |
bevanjkay
reviewed
Jun 13, 2026
Comment on lines
+28
to
+30
| def install | ||
| generate_completions_from_executable(bin/"btp", "--autocomplete=init:", shells: [:bash, :zsh, :pwsh]) | ||
| end |
Member
There was a problem hiding this comment.
Suggested change
| def install | |
| generate_completions_from_executable(bin/"btp", "--autocomplete=init:", shells: [:bash, :zsh, :pwsh]) | |
| end | |
| generate_completions_from_executable "btp", "--autocomplete=init:" |
This is the required format for a Cask.
Author
There was a problem hiding this comment.
Wait do I also have to omit the shells here?
Member
Closed-source tools are always Casks, as they cannot be built from source as a Formula. |
abb906e to
a0dcaa7
Compare
7b89194 to
01eecc7
Compare
8caeb93 to
f24ad96
Compare
f24ad96 to
9d66d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.Explain the brew style output and let it fix it as brew style requires a brew tap to work.
Verification: CI didn't work previously; now it works; I am not familiar with ruby style code