Mark override functions#1319
Merged
Merged
Conversation
tobil4sk
commented
Mar 14, 2026
If c++11 is used, we need to mark override functions. For older c++ versions we just define the macro as empty. Code that is only used for HXCPP_API_LEVEL 500 and above already requires c++11 as a minimum, so there we can just use the override keyword directly without the macro, as is already the case in some places.
The const markers did not match the definition in hx::Object, so they were not overriding the parent class method correctly. If we remove them then they can be marked as override.
Older versions of haxe do not generate overrides so they will keep showing warnings. By omitting any overrides, we prevent these warnings from showing up.
tobil4sk
force-pushed
the
fix/override-warnings
branch
from
af14867 to
a8e83bb
Compare
MAJigsaw77
approved these changes
Mar 19, 2026
Contributor
|
Can you resolve the conflicts? I'll merge once that's done. |
Member
Author
|
Should be up-to-date now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If c++11 is used, we need to mark override functions. For older c++ versions we just define the macro as empty.
Code that is only used for HXCPP_API_LEVEL 500 and above already requires c++11 as a minimum, so there we can just use the override keyword directly without the macro, as is already the case in some places.
To fully get rid of all warnings, we also need haxe to generate overrides where needed, i.e. HaxeFoundation/haxe#12840.
Closes #1318 and #1334.