Skip to content

Add psc_auto_connection_policy_enabled and output-only fields to Clou…#17962

Open
hannahjiang-0415 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
hannahjiang-0415:cloud-sql-psc-auto-connection-policy
Open

Add psc_auto_connection_policy_enabled and output-only fields to Clou…#17962
hannahjiang-0415 wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
hannahjiang-0415:cloud-sql-psc-auto-connection-policy

Conversation

@hannahjiang-0415

Copy link
Copy Markdown

…d SQL

Added:

  • psc_config.psc_auto_connection_policy_enabled (writable)
  • psc_config.psc_auto_connections.service_connection_policy (output only)
  • psc_config.psc_auto_connections.service_connection_policy_creation_result (output only)

These fields support the automatic creation and tracking of service connection policies for PSC auto-connections.

release-note:enhancement Cloud SQL: added support for psc_auto_connection_policy_enabled and related output-only status fields.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


…d SQL

Added:
- psc_config.psc_auto_connection_policy_enabled (writable)
- psc_config.psc_auto_connections.service_connection_policy (output only)
- psc_config.psc_auto_connections.service_connection_policy_creation_result (output only)

These fields support the automatic creation and tracking of service connection policies for PSC auto-connections.

release-note:enhancement Cloud SQL: added support for psc_auto_connection_policy_enabled and related output-only status fields.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 13, 2026
@github-actions github-actions Bot requested a review from shuyama1 June 13, 2026 02:07
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/sqladmin-cp and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 16, 2026
@modular-magician

modular-magician commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 38a3b42:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 143 insertions(+), 27 deletions(-)
google-beta provider View Diff 4 files changed, 143 insertions(+), 27 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • sql

Please fix the compilation errors to complete your PR.

View the build log

@hannahjiang-0415, @shuyama1 VCR tests complete for 38a3b42!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 16, 2026
@github-actions

Copy link
Copy Markdown

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 17, 2026
@modular-magician

modular-magician commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5d8b322:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 144 insertions(+), 28 deletions(-)
google-beta provider View Diff 5 files changed, 144 insertions(+), 28 deletions(-)
terraform-google-conversion View Diff 1 file changed, 1 insertion(+), 1 deletion(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_sql_database_instance
    • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
    • Fields: [settings.ip_configuration.psc_config.psc_auto_connection_policy_enabled]

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccSqlDatabaseInstance_withPSCEnabled_withAutoConnectionPolicy

Analytics

Total Tests Passed Skipped Affected
0 0 0 0
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Caution

🔴 Errors occurred during REPLAYING mode. Please check the build log for details.

View the replaying VCR build log

@hannahjiang-0415, @shuyama1 VCR tests complete for 5d8b322!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants