Implement compute instance groups plural datasource by olpapchenko · Pull Request #17929 · GoogleCloudPlatform/magic-modules

olpapchenko · 2026-06-11T12:24:44Z

Fixes hashicorp/terraform-provider-google#18941

`google_compute_instance_groups`

github-actions · 2026-06-11T12:25:17Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-06-11T12:34:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 51219e0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	2 files changed, 211 insertions(+)
`google-beta` provider	View Diff	2 files changed, 211 insertions(+)

Missing doc report (experimental)

The following data sources are missing documents:

google_compute_instance_groups, expect file /website/docs/d/compute_instance_groups.html.markdown to exist.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1473	1379	93	1

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

TestAccDataSourceGoogleComputeInstanceGroups

View the replaying VCR build log

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccDataSourceGoogleComputeInstanceGroups

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@olpapchenko, @roaks3 VCR tests complete for 51219e0!

roaks3

Very high-level initial comment, but I think we'd want a documentation page for this?

olpapchenko · 2026-06-12T07:35:08Z

Very high-level initial comment, but I think we'd want a documentation page for this?

Added documentation.

modular-magician · 2026-06-12T07:42:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 670d89a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 283 insertions(+)
`google-beta` provider	View Diff	3 files changed, 283 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1473	1380	93	0

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@olpapchenko, @roaks3 VCR tests complete for 670d89a!

github-actions · 2026-06-17T11:18:39Z

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

roaks3

LGTM, although we should convert to HTTP client to avoid introducing something that will need to immediately change (compute is in-progress on a large migration to HTTP clients)

roaks3 · 2026-06-17T21:14:33Z

+
+	instanceGroups := make([]map[string]interface{}, 0)
+
+	instanceGroupsList, err := NewClient(config, userAgent).InstanceGroups.List(project, zone).Filter(filter).Do()


It looks like the instance_group resource and datasource were already migrated to using HTTP clients. Could you modify this to do the same, so that it doesn't need to be converted in the near-term by someone else?

I have changed the implementation to http, + added pagination support.

modular-magician · 2026-06-18T08:20:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 72010f8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 334 insertions(+)
`google-beta` provider	View Diff	3 files changed, 334 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1484	1391	93	0

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@olpapchenko, @roaks3 VCR tests complete for 72010f8!

roaks3

LGTM, just added a few notes from comparing implementation against existing datasource and resource

roaks3 · 2026-06-18T16:17:00Z

+				var network string
+				if v, ok := ig["network"].(string); ok && v != "" {
+					var err error
+					network, err = tpgresource.GetRelativePath(v)


Just a couple comments on the custom transforms here: is this part needed? It looked to me like the singular datasource and resource do not do this (might have missed something though)

modular-magician · 2026-06-19T09:41:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fdb0ad9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
`google` provider	View Diff	3 files changed, 313 insertions(+)
`google-beta` provider	View Diff	3 files changed, 313 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1484	1391	93	0

Affected Service Packages

compute

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@olpapchenko, @roaks3 VCR tests complete for fdb0ad9!

github-actions Bot requested a review from roaks3 June 11, 2026 12:25

roaks3 reviewed Jun 11, 2026

View reviewed changes

olpapchenko force-pushed the ig-plural-ds branch from 51219e0 to 670d89a Compare June 12, 2026 07:32

github-actions Bot requested a review from roaks3 June 12, 2026 07:33

roaks3 reviewed Jun 17, 2026

View reviewed changes

olpapchenko force-pushed the ig-plural-ds branch from 670d89a to 72010f8 Compare June 18, 2026 08:11

github-actions Bot requested a review from roaks3 June 18, 2026 08:12

roaks3 reviewed Jun 18, 2026

View reviewed changes

Implement compute instance groups plural datasource

fdb0ad9

olpapchenko force-pushed the ig-plural-ds branch from 72010f8 to fdb0ad9 Compare June 19, 2026 09:32

github-actions Bot requested a review from roaks3 June 19, 2026 09:32


		instanceGroups := make([]map[string]interface{}, 0)

		instanceGroupsList, err := NewClient(config, userAgent).InstanceGroups.List(project, zone).Filter(filter).Do()

Conversation

olpapchenko commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

modular-magician commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Missing doc report (experimental)

Test report

Analytics

Action taken

Uh oh!

roaks3 left a comment

Choose a reason for hiding this comment

Uh oh!

olpapchenko commented Jun 12, 2026

Uh oh!

modular-magician commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

roaks3 left a comment

Choose a reason for hiding this comment

Uh oh!

roaks3 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

olpapchenko Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Uh oh!

roaks3 left a comment

Choose a reason for hiding this comment

Uh oh!

roaks3 Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diff report

Test report

Analytics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

modular-magician commented Jun 11, 2026 •

edited

Loading

modular-magician commented Jun 12, 2026 •

edited

Loading

modular-magician commented Jun 18, 2026 •

edited

Loading

modular-magician commented Jun 19, 2026 •

edited

Loading