Skip to content

refactor(vertexai): remove vertexai/gemini/GetMediaTokenCount.java related to decommissioned generativeaionvertexai_gemini_token_count_advanced region tag#10299

Open
Kef131 wants to merge 3 commits into
mainfrom
refactor(vertexai)-remove-deprecated-tokencountadvanced-tag
Open

refactor(vertexai): remove vertexai/gemini/GetMediaTokenCount.java related to decommissioned generativeaionvertexai_gemini_token_count_advanced region tag#10299
Kef131 wants to merge 3 commits into
mainfrom
refactor(vertexai)-remove-deprecated-tokencountadvanced-tag

Conversation

@Kef131

@Kef131 Kef131 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/530681617

Region tag generativeaionvertexai_gemini_token_count_advanced shows no reference in devsite along no use of the file.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jul 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the region tags for generativeaionvertexai_gemini_token_count_advanced from the GetMediaTokenCount.java file. As there are no review comments, I have no feedback to provide.

@Kef131 Kef131 changed the title refactor(vertexai): remove decommisioned generativeaionvertexai_gemini_token_count_advanced region tag refactor(vertexai): remove vertexai/gemini/GetMediaTokenCount.java related to decommissioned generativeaionvertexai_gemini_token_count_advanced region tag Jul 3, 2026
@Kef131 Kef131 marked this pull request as ready for review July 3, 2026 18:08
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners July 3, 2026 18:08
@snippet-bot

snippet-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have validated that there is no reference to this file. Good to go.

@Kef131 Kef131 self-assigned this Jul 3, 2026
@Kef131 Kef131 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants