Skip to content

Add a separate documentation for supported plot and distance units#4359

Open
seisman wants to merge 19 commits into
mainfrom
doc/units
Open

Add a separate documentation for supported plot and distance units#4359
seisman wants to merge 19 commits into
mainfrom
doc/units

Conversation

@seisman

@seisman seisman commented Jan 18, 2026

Copy link
Copy Markdown
Member

@seisman seisman requested a review from Copilot April 1, 2026 09:46
@seisman seisman added the documentation Improvements or additions to documentation label Apr 1, 2026
@seisman seisman added this to the 0.19.0 milestone Apr 1, 2026
@seisman

seisman commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

@copilot Please update the docstrings in pygmt/helpers/decorators.py, pygmt/src/x2sys_init.py, pygmt/src/scalebar.py, and pygmt/src/sphdistance.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated Technical Reference page documenting GMT/PyGMT unit codes (plot vs distance units) and updates API documentation to reference this centralized unit documentation.

Changes:

  • Added a new Technical Reference page techref/units.md describing supported plot and distance unit codes.
  • Included the new units page in the Technical Reference toctree.
  • Updated pygmt.grdproject parameter docs to reference the new units documentation instead of repeating unit lists inline.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pygmt/src/grdproject.py Replaces inline unit-code lists with links to the new units Technical Reference page/sections.
doc/techref/units.md New documentation page enumerating plot (dimension) and distance unit codes.
doc/techref/index.md Adds units.md to the Technical Reference toctree so it is built and discoverable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pygmt/src/grdproject.py Outdated
Comment thread pygmt/src/grdproject.py Outdated
Copilot AI and others added 2 commits April 1, 2026 09:58

Copilot AI commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@copilot Please update the docstrings in pygmt/helpers/decorators.py, pygmt/src/x2sys_init.py, pygmt/src/scalebar.py, and pygmt/src/sphdistance.py

Done in commit fd93a03. Updated the docstrings in all four files to reference the new /techref/units documentation page instead of listing units inline, consistent with the changes already made in grdproject.py.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI changed the title POC: Add a separate documentation for supported plot and distance units Fix broken section anchor links in unit documentation references Apr 1, 2026
Copilot AI changed the title Fix broken section anchor links in unit documentation references Add automated ReadTheDocs preview links to PR descriptions Apr 1, 2026
@seisman seisman changed the title Add automated ReadTheDocs preview links to PR descriptions POC: Add a separate documentation for supported plot and distance units Apr 1, 2026
@seisman seisman removed this from the 0.19.0 milestone May 23, 2026
@seisman seisman changed the title POC: Add a separate documentation for supported plot and distance units Add a separate documentation for supported plot and distance units Jun 25, 2026
@seisman seisman added this to the 0.19.0 milestone Jun 25, 2026
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 25, 2026
@seisman seisman marked this pull request as ready for review June 25, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs review This PR has higher priority and needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants