[WIP] [Performance] Resolve destinationReportID before confirmation mount in global-create#94459
Draft
JakubKorytko wants to merge 5 commits into
Draft
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fix single-screen global-create flows (workspace expenses, self-DM tracking) where
transaction.reportIDwas undefined at Confirmation mount time, causing the pre-insert effect to miss its window. ExtractedresolveEarlyReportIDinuseResetIOUTypeto settransaction.reportIDimmediately afterinitMoneyRequest. Also resethasPreInsertFiredin the pre-insert cleanup so it can re-fire whendestinationReportIDtransitions from undefined to a valid value.Sentry Evidence
Note: This bug only affects the
NEW_MANUAL_EXPENSE_FLOWbeta (single-screen amount + confirmation). The old multi-step flow is unaffected.This is a regression introduced by the single-screen manual flow change (
IOURequestStartPagenow rendersIOURequestStepConfirmationdirectly on the Manual tab). The old multi-step flow usedAmountSubmission.tswhich calledsetTransactionReportbefore navigation to confirmation:With the single-screen flow, this call is bypassed entirely. The embedded confirmation screen resolves default participants via
useDefaultParticipantsbut never callssetTransactionReportfor workspace participants. This causesdestinationReportIDto be undefined at first render, the pre-insert effect fires with no destination, and subsequentsetTransactionReporttriggers a cleanup that removes the pre-insert without replacement (becausehasPreInsertFiredstays true).The impact contributes to the ~56% DEFAULT handler rate observed in Sentry (5.2k default vs 4k non-default in 24h).
Fixed Issues
$ #94462
PROPOSAL: N/A
Tests
Prerequisites: Enable the
NEW_MANUAL_EXPENSE_FLOWbeta.[Sentry][ManualSubmitToDestinationVisible] Ending spanappears in the console with a sub-two-second duration andfast_path_handleris NOTdefaultOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari