Prevent loading older chats while hidden history is shown#94444
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-25.at.9.58.12.PM.movAndroid: mWeb ChromeScreen.Recording.2026-06-25.at.10.03.24.PM.moviOS: HybridAppScreen.Recording.2026-06-25.at.10.06.06.PM.moviOS: mWeb SafariScreen.Recording.2026-06-25.at.10.01.22.PM.movMacOS: Chrome / SafariScreen.Recording.2026-06-25.at.9.49.50.PM.movScreen.Recording.2026-06-25.at.9.55.10.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.20-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR is a purely internal bug fix in There is no user-facing change to document:
Since the help site documents end-user behavior and this change is invisible to users, no draft PR was created. |
|
This PR failing because of the issue #94662 Bug7191580_1782441295688.concierge.mp4 |
|
@jponikarchuk That issue looks more like expected behaviour, explained here: #94662 (comment) |
|
@VickyStash PR is passed, comment |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
For Concierge chats with hidden history,
GetOlderActions(onEndReached) API call can be called in a loop.We should block it if the history is hidden.
Fixed Issues
$ #93916
PROPOSAL: N/A
Tests
Pre-conditions:
Show historybutton is shown)GetOlderActionsAPI calls in the Network tabShow historyand scroll to topGetOlderActionsis called when we need to load older messages.Offline tests
Same, as in Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mp4