Fix unresponsive app after Home Recently added View all expenses by MelvinBot · Pull Request #94435 · Expensify/App

MelvinBot · 2026-06-24T09:41:09Z

Explanation of Change

The Home "Recently added" overflow menu's View all expenses item navigated to the Spend tab synchronously inside the PopoverMenu item's onSelected, while the popover was still open. On native the popover is a full-screen Modal with a touch-capturing backdrop, and the Home tab stays mounted when switching tabs — so the Navigation.navigate(SEARCH_ROOT) raced the modal's slide-out dismissal and could leave the backdrop layered on top of the Spend tab, swallowing every tap and making the app appear unresponsive.

This adds shouldCallAfterModalHide: true to the menu item so the navigation is deferred (via Modal.close()) until the popover has fully hidden, matching the established pattern used by the FAB menu items (e.g. CreateReportMenuItem/ExpenseMenuItem) and the workspace three-dots menus. With the backdrop gone before navigation, no overlay can block touches on the destination tab.

Fixed Issues

$ #94410
PROPOSAL: #94410 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Sign in to an account that has at least one expense.
On the Home tab, tap the 3-dot overflow in the "Recently added" section, then tap "View all expenses".
Verify you navigate to the Spend tab and the app remains fully responsive — tapping to open another tab or page works immediately.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

Sign in (iOS native) to an account that has at least one expense.
On the Home tab, tap the 3-dot overflow in "Recently added", then tap "View all expenses".
On the Spend tab, tap anything to open another tab/page and verify the app responds normally (does not freeze).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…isses Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot · 2026-06-24T09:41:30Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixHomeRecentlyAddedViewAllUnresponsive
git checkout -b claude-fixHomeRecentlyAddedViewAllUnresponsive upstream/claude-fixHomeRecentlyAddedViewAllUnresponsive
git push -u origin claude-fixHomeRecentlyAddedViewAllUnresponsive

Then you can close this PR and open a new one from your fork.

ZhenjaHorbach · 2026-06-24T09:42:09Z

@MelvinBot
Complete the author checklist and open the PR

melvin-bot · 2026-06-24T09:45:53Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-06-24T09:46:01Z

🤖 Completed the author checklist and marked this PR ready for review.

What I checked off (verifiable from the diff/body):

Linked issue, documented test/offline/QA steps, and code-pattern/guideline items.
The conditional items that are N/A for this change — the diff only adds shouldCallAfterModalHide: true to one PopoverMenu item, so there are no new files, CSS, assets, message-editing code, generic-component, Storybook, deeplink, or UI changes.

Left unchecked — these need you (the human co-author), since they require real on-device testing I can't perform:

Screenshots/videos on all platforms
Running & verifying tests on Android Native, Android mWeb, iOS Native (the platform this fix targets), iOS mWeb Safari, and MacOS Chrome/Safari
Verifying no console errors, the offline/High-Traffic-account tests, and impacted-component testing
Unit tests (a native modal-dismissal timing fix is impractical to unit test — your call on whether to add one)

Please record the Screenshots/Videos and tick the remaining platform boxes before a reviewer signs off.

ZhenjaHorbach · 2026-06-24T09:47:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-24.11.44.36.mov

Android: mWeb Chrome

2026-06-24.11.44.08.mov

iOS: HybridApp

2026-06-24.11.44.36.mov

iOS: mWeb Safari

2026-06-24.11.44.08.mov

MacOS: Chrome / Safari

2026-06-24.11.45.51.mov

ZhenjaHorbach · 2026-06-24T09:48:28Z

@MelvinBot
Paste this checklist in the author checklist

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

grgia · 2026-06-24T09:51:51Z

+                        // Defer navigation until the popover modal has fully dismissed. On native the popover is a
+                        // full-screen Modal with a backdrop; navigating to another tab synchronously races the
+                        // dismissal and can leave the backdrop mounted on top of the destination, blocking all taps.


@ZhenjaHorbach @MelvinBot please remove this comment

Fair enough 😅

ZhenjaHorbach · 2026-06-24T09:53:34Z

@MelvinBot
Remove comments from your ifx

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot · 2026-06-24T09:58:16Z

🤖 Removed the explanatory comments from the shouldCallAfterModalHide: true change in src/pages/home/RecentlyAddedSection/index.tsx. Pushed as 153ead9.

melvin-bot · 2026-06-24T09:58:17Z

@cretadn22 @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-06-24T16:56:20Z

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-24T16:56:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-24T17:02:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94435.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e319170143f-652c483-fb1730835cfce1cf5efa2301921ba05c60351016/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e319170-652c483-2c164498ecbc556b3ba3ccd2107d8fe82df4e322/index.html

Web 🕸️
https://94435.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…iewAllUnresponsive Fix unresponsive app after Home Recently added View all expenses (cherry picked from commit e319170) (cherry-picked to staging by blimpich)

OSBotify · 2026-06-24T17:40:38Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.18-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-24T17:43:20Z

🤖 No help site changes required.

This PR is a native-only behavioral bug fix — it adds shouldCallAfterModalHide: true to the "View all expenses" menu item so navigation is deferred until the popover modal has fully dismissed, preventing the backdrop from blocking taps on the destination tab.

The documented user-facing behavior is unchanged: tapping View all expenses in the Home "Recently added" section still navigates to the same place — it just no longer freezes the app on native. There's no new feature, UI element, label, setting, or workflow to document.

I searched App/docs/articles for the affected flow and found no article that describes the "Recently added" overflow menu or this navigation behavior, so there is nothing to update.

Because no changes are needed, I did not create a docs draft PR.

@ZhenjaHorbach, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review — note that since no help site changes were required, no docs PR was created; if you believe a help article should be added or updated for this flow, let me know and I'll draft one.

OSBotify · 2026-06-24T19:16:56Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.18-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-06-24T19:40:36Z

🚀 Cherry-picked to staging by https://github.com/blimpich in version: 9.4.19-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-24T19:42:23Z

🤖 No help site changes required.

I reviewed the change in this PR against App/docs/articles. The diff only adds shouldCallAfterModalHide: true to the "View all expenses" item in the Home "Recently added" overflow menu — a native-only bug fix that defers navigation until the popover modal finishes dismissing, so the backdrop can no longer freeze the destination tab.

This is purely an internal behavior/timing fix:

No new or renamed feature, tab, setting, button, or label.
No change to any user-facing workflow — "View all expenses" still navigates to the same place; it just no longer leaves the app unresponsive.

The help site documents what features do, not modal-dismissal internals, and nothing documented changes here. Accordingly, I did not create a docs PR — so there's no linked help site PR to review.

ZhenjaHorbach, if you believe a help article is affected, let me know which one and I'll draft the update.

OSBotify · 2026-06-25T21:31:07Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.19-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix: defer Home Recently added View all navigation until popover dism…

ad1d3a0

…isses Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot assigned ZhenjaHorbach Jun 24, 2026

MelvinBot requested a review from a team June 24, 2026 09:41

MelvinBot mentioned this pull request Jun 24, 2026

[Due for payment 2026-07-02] [Due for payment 2026-07-01] [$250] Home/Spend-App becomes unresponsive after tapping View all expenses #94410

Closed

7 tasks

MelvinBot marked this pull request as ready for review June 24, 2026 09:45

MelvinBot requested a review from a team as a code owner June 24, 2026 09:45

melvin-bot Bot requested review from DylanDylann and removed request for a team June 24, 2026 09:45

melvin-bot Bot requested review from heyjennahay and removed request for a team June 24, 2026 09:45

grgia reviewed Jun 24, 2026

View reviewed changes

Remove explanatory comments from View all expenses menu item

153ead9

Co-authored-by: Yauheni Horbach <ZhenjaHorbach@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner June 24, 2026 09:58

melvin-bot Bot requested review from cretadn22 and grgia June 24, 2026 09:58

melvin-bot Bot removed the request for review from a team June 24, 2026 09:58

ZhenjaHorbach approved these changes Jun 24, 2026

View reviewed changes

blimpich approved these changes Jun 24, 2026

View reviewed changes

blimpich merged commit e319170 into main Jun 24, 2026
38 checks passed

blimpich deleted the claude-fixHomeRecentlyAddedViewAllUnresponsive branch June 24, 2026 16:50

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 24, 2026

OSBotify mentioned this pull request Jun 24, 2026

Deploy Checklist: New Expensify 2026-06-23 #94371

Closed

48 tasks

kacper-mikolajczak mentioned this pull request Jun 30, 2026

Investigate agent device as Melvin tool for mobile device testing #87030

Open

Uh oh!

Conversation

MelvinBot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

ZhenjaHorbach commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

ZhenjaHorbach commented Jun 24, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jun 24, 2026

PR Author Checklist

Screenshots/Videos

Uh oh!

grgia Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 24, 2026

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

melvin-bot Bot commented Jun 24, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 24, 2026

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 24, 2026

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Jun 24, 2026 •

edited

Loading