Remove pay backend#9254
Draft
Lagrang3 wants to merge 2 commits into
Draft
Conversation
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rustyrussell deprecated
payin #9110, but he forgot to deprecatexpay-handle-pay.This PR:
xpay-handle-payfor v26.09,pay's backend computation, ie. everypaycommand will be handled byxpay, though we still keep thepayAPI available as promised by our deprecation rules,xpayand therefore we initialize the plugin with synchronous RPCs avoiding initialization race conditions.This fixes #9248 without the need of #9250.