Scheduler — Refactor scheduler.d.ts file#34247
Closed
sjbur wants to merge 8 commits into
Closed
Conversation
sjbur
commented
Jul 9, 2026
| menuItemTemplate: {}, | ||
| name: String as PropType<string | FormPredefinedButtonItem | SchedulerPredefinedToolbarItem>, | ||
| options: Object as PropType<DateNavigatorItemProperties | Record<string, any> | dxButtonGroupOptions>, | ||
| options: Object as PropType<DateNavigatorItemProperties | Record<string, any>>, |
Contributor
Author
There was a problem hiding this comment.
DateNavigatorItemProperties extends dxButtonGroupOptions, so there is no need for dxButtonGroupOptions here
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Scheduler TypeScript declaration surface to use the public Properties type aliases (instead of the deprecated dxSchedulerOptions) and to reference nested widget types (dxButtonGroup.Item, dxToolbar.Item) consistently across bundled declarations and wrapper typings.
Changes:
- Updated
dxSchedulerto extendWidget<DevExpress.ui.dxScheduler.Properties>/Widget<Properties>rather thanWidget<dxSchedulerOptions>. - Refined
dxSchedulerOptionstoOmitand then explicitly redeclare base widget event handlers with Scheduler-specific event types. - Normalized
DateNavigatorItemProperties/ToolbarItemto usedxButtonGroup.Properties+dxButtonGroup.ItemanddxToolbar.Item, and adjusted Vue wrapper prop unions accordingly.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Aligns bundled Scheduler typings to use DevExpress.ui.dxScheduler.Properties and nested widget Properties/Item types. |
| packages/devextreme/js/ui/scheduler.d.ts | Refactors Scheduler public typings: Properties-based widget generic, explicit event overrides via Omit, and normalized toolbar/date navigator related types. |
| packages/devextreme-vue/src/scheduler.ts | Updates Vue wrapper prop typings to match the refactored Scheduler type definitions (removes redundant dxButtonGroupOptions union member). |
mpreyskurantov
requested changes
Jul 10, 2026
mpreyskurantov
left a comment
Contributor
There was a problem hiding this comment.
blocked,
should be a feature branch from the upstream remote (not a fork),
in the feature/* name format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.