Skip to content

Document NO_PROXY configuration and matching rules#37802

Open
beommoyang wants to merge 5 commits into
masterfrom
beommo.yang-add-no-proxy-description
Open

Document NO_PROXY configuration and matching rules#37802
beommoyang wants to merge 5 commits into
masterfrom
beommo.yang-add-no-proxy-description

Conversation

@beommoyang

Copy link
Copy Markdown
Contributor

Added section on NO_PROXY accepted values and matching rules for Agent HTTP(S) requests.

What does this PR do? What is the motivation?

Added a new NO_PROXY Accepted Values section explaining the difference between exact matching (default) and nonexact matching (no_proxy_nonexact_match: true), including matching rules for domain names, subdomains, CIDR ranges, exact IPs, and hostnames.

Merge readiness

  • Ready for merge

For Datadog employees:

  • ⚠️ Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR.
  • 🤖 New: Comment with /review to run an automated check that catches common issues before a Documentation team member reviews your PR.

AI assistance

Used Claude Code for research and drafting.

Additional notes

Added section on `NO_PROXY` accepted values and matching rules for Agent HTTP(S) requests.
@beommoyang beommoyang requested a review from a team as a code owner June 26, 2026 19:28
@beommoyang

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude. AI-generated; verify before acting.

Three style nits on the new section: heading should use sentence case, the recommendation can be more direct, and "nor" reads awkwardly without "neither".

Reviewed 862475cb77837f68ea870f3964c6af8676f6720aworkflow run

Comment thread content/en/agent/configuration/proxy.md Outdated

## `NO_PROXY` Accepted Values

By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Use a direct, active voice instead of "It is recommended to". Also, the existing config example above (line 53) already uses no_proxy_nonexact_match: true and notes that it's recommended — consider whether this sentence still adds value or could be tightened.

Suggested change
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). Datadog recommends enabling `no_proxy_nonexact_match` so the Agent matches `NO_PROXY` values using the same rules as Agent integrations.

The following rules apply to Agent integrations (and the whole Agent when `no_proxy_nonexact_match` is enabled):
* A domain name matches that name and all subdomains, for example:
- `datadoghq.com` matches `app.agent.datadoghq.com`, `www.datadoghq.com`, `datadoghq.com`, but **not** `www.notdatadoghq.com`
- `datadoghq` matches `frontend.datadoghq`, `backend.datadoghq`, but **not** `www.datadoghq.com` nor `www.datadoghq.eu`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: "nor" without a preceding "neither" reads awkwardly; use "or" for parallelism with the other bullets.

Suggested change
- `datadoghq` matches `frontend.datadoghq`, `backend.datadoghq`, but **not** `www.datadoghq.com` nor `www.datadoghq.eu`
- `datadoghq` matches `frontend.datadoghq`, `backend.datadoghq`, but **not** `www.datadoghq.com` or `www.datadoghq.eu`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this suggestion, please update - thank you!

beommoyang and others added 2 commits June 26, 2026 16:09
Expanded proxy configuration options for Kubernetes deployments, including Helm and Datadog Operator methods.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@beommoyang

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude. AI-generated; verify before acting.

Two minor style nits — content reads cleanly and the new Kubernetes examples are well-structured and consistent with existing patterns in the file.

Reviewed 72db01179de3b57fa127adb5403c71346995bb99workflow run

## Configure the Datadog Agent

There are two options for configuring the Datadog Agent to use a proxy.
There are several options for configuring the Datadog Agent to use a proxy depending on your deployment method.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Add a comma before the qualifying clause for readability.

Suggested change
There are several options for configuring the Datadog Agent to use a proxy depending on your deployment method.
There are several options for configuring the Datadog Agent to use a proxy, depending on your deployment method.


## `NO_PROXY` accepted values

By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Prefer active voice — this matches the existing phrasing later in the file ("Datadog recommends using an HTTP proxy like Squid").

Suggested change
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). Datadog recommends enabling `no_proxy_nonexact_match` so the Agent matches `NO_PROXY` values with the same rules used for Agent integrations.

@jeff-morgan-dd jeff-morgan-dd self-assigned this Jun 26, 2026

@jeff-morgan-dd jeff-morgan-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Please see a couple of non-blocking recommended style guide edits.


## `NO_PROXY` accepted values

By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). It is recommended to enable `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.
By default, `no_proxy`/`NO_PROXY` must match endpoints exactly for Agent HTTP(S) requests (except requests performed by Agent integrations). Datadog recommends enabling `no_proxy_nonexact_match` to make the Agent match `NO_PROXY` values with the same rules used for Agent integrations.

The following rules apply to Agent integrations (and the whole Agent when `no_proxy_nonexact_match` is enabled):
* A domain name matches that name and all subdomains, for example:
- `datadoghq.com` matches `app.agent.datadoghq.com`, `www.datadoghq.com`, `datadoghq.com`, but **not** `www.notdatadoghq.com`
- `datadoghq` matches `frontend.datadoghq`, `backend.datadoghq`, but **not** `www.datadoghq.com` nor `www.datadoghq.eu`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this suggestion, please update - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants