Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Breaking Changes

- **Docker default port changed from 8080 to 80**: The `ENV DevOidcToolkit__Port=8080` environment variable has been removed from the Dockerfile. The application now listens on port 80 by default (the application's built-in default). Docker port mappings should be updated from `-p 8080:8080` to `-p 8080:80`. This fixes a bug where setting `Port` in `config.json` had no effect (see [#26](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/26))

## [0.6.0]
- Add optional SQLite persistence via `Database.SqliteFile` config option; defaults to in-memory when not set (see [#20](https://github.com/BusinessSimulations/dev-oidc-toolkit/issues/20))

Expand Down
8 changes: 4 additions & 4 deletions DevOidcToolkit.Documentation/docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Dev OIDC Toolkit can be configured using environment variables. The environment
Here is how to run the application in a Docker container with environment variables:

```bash
docker run -p 8080:8080 \
docker run -p 8080:80 \
-e DevOidcToolkit__Users__0__Email=test@localhost \
-e DevOidcToolkit__Users__0__FirstName=Test \
-e DevOidcToolkit__Users__0__LastName=User \
Expand Down Expand Up @@ -166,7 +166,7 @@ When running the application in a Docker container, the `config.json` file shoul
Here is how to run the application in a Docker container with a configuration file mounted:

```bash
docker run -p 8080:8080 -v ./config.json:/app/config.json ghcr.io/businesssimulations/dev-oidc-toolkit
docker run -p 8080:80 -v ./config.json:/app/config.json ghcr.io/businesssimulations/dev-oidc-toolkit
```

### Reference
Expand Down Expand Up @@ -485,7 +485,7 @@ In-memory database (default, no persistence):
```json
{
"DevOidcToolkit": {
"Port": 8080,
"Port": 80,
"Issuer": "https://fake-issuer.example.com",
"Users": [
{
Expand All @@ -512,7 +512,7 @@ SQLite database (data persists across restarts):
```json
{
"DevOidcToolkit": {
"Port": 8080,
"Port": 80,
"Database": {
"SqliteFile": "/data/dev-oidc-toolkit.db"
},
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ COPY --from=build /app/dist .

RUN apt-get update && apt-get install -y --no-install-recommends curl && rm -rf /var/lib/apt/lists/*

ENV DevOidcToolkit__Address=0.0.0.0

ENTRYPOINT ["dotnet", "dev-oidc-toolkit.dll"]

ENV DevOidcToolkit__Port=8080
ENV DevOidcToolkit__Address=0.0.0.0
EXPOSE 8080
EXPOSE 80

HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
CMD curl -f http://localhost:${DevOidcToolkit__Port}/healthz/live || exit 1
CMD curl -f http://localhost:80/healthz/live || exit 1
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Access the documentatation here: <https://dev-oidc-toolkit.readthedocs.io/en/lat
The easiest way to run this application is using docker, use this command:

```bash
docker run -p 8080:8080 \
docker run -p 8080:80 \
-e DevOidcToolkit__Users__0__Email=test@localhost \
-e DevOidcToolkit__Users__0__FirstName=Test \
-e DevOidcToolkit__Users__0__LastName=User \
Expand Down
Loading