return declared InetAddress, WktString and Float types on-premise#133
Merged
Conversation
The on-premise engine declared `InetAddress`/`WktString`/`Float` on its typed getters (Ip, Areas, Latitude/Longitude) but returned `String` at runtime, throwing `ClassCastException` for consumers and diverging from the cloud engine. These getters now return the declared types. ## Changes - On-premise scalar getters now produce `InetAddress`, `WktString` and `Float`, matching the generated interface and the cloud engine. - Values are wrapped from the existing native string accessor (and double for `Float`); no new abstract methods, so subclasses and binary compatibility are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The on-premise engine declared
InetAddress/WktString/Floaton its typed getters (Ip, Areas, Latitude/Longitude) but returnedStringat runtime, throwingClassCastExceptionfor consumers and diverging from the cloud engine. These getters now return the declared types.Changes
InetAddress,WktStringandFloat, matching the generated interface and the cloud engine.Float); no new abstract methods, so subclasses and binary compatibility are unaffected.