Skip to content

Commit 3afa423

Browse files
authored
AdvLoggerPkg: Initialize structures in LineParserTestApp (#828)
## Description Logger info structures are not zeroed and initialized right now, causing garbage data to be read in some fields and impact test results. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested - Run LineParserTestApp on QEMU Q35 ## Integration Instructions - N/A Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
1 parent 3496fc1 commit 3afa423

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

AdvLoggerPkg/UnitTests/LineParser/LineParserTestApp.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,9 @@ InitializeInMemoryLog (
408408
UT_ASSERT_TRUE (FALSE);
409409
}
410410

411+
ZeroMem ((VOID *)mLoggerInfo, sizeof (*mLoggerInfo));
411412
mLoggerInfo->Signature = ADVANCED_LOGGER_SIGNATURE;
413+
mLoggerInfo->Version = ADVANCED_LOGGER_INFO_VER;
412414
mLoggerInfo->GoneVirtual = FALSE;
413415
mLoggerInfo->AtRuntime = FALSE;
414416
mLoggerInfo->LogBufferSize = EFI_PAGE_SIZE * IN_MEMORY_PAGES - sizeof (*mLoggerInfo);
@@ -457,7 +459,9 @@ InitializeInMemoryLogV2 (
457459
UT_ASSERT_TRUE (FALSE);
458460
}
459461

462+
ZeroMem ((VOID *)mLoggerInfo, sizeof (*mLoggerInfo));
460463
mLoggerInfo->Signature = ADVANCED_LOGGER_SIGNATURE;
464+
mLoggerInfo->Version = ADVANCED_LOGGER_INFO_VER;
461465
mLoggerInfo->GoneVirtual = FALSE;
462466
mLoggerInfo->AtRuntime = FALSE;
463467
mLoggerInfo->LogBufferSize = EFI_PAGE_SIZE * IN_MEMORY_PAGES - sizeof (*mLoggerInfo);
@@ -507,7 +511,9 @@ InitializeInMemoryLogV2Hybrid (
507511
UT_ASSERT_TRUE (FALSE);
508512
}
509513

514+
ZeroMem ((VOID *)mLoggerInfo, sizeof (*mLoggerInfo));
510515
mLoggerInfo->Signature = ADVANCED_LOGGER_SIGNATURE;
516+
mLoggerInfo->Version = ADVANCED_LOGGER_INFO_VER;
511517
mLoggerInfo->GoneVirtual = FALSE;
512518
mLoggerInfo->AtRuntime = FALSE;
513519
mLoggerInfo->LogBufferSize = EFI_PAGE_SIZE * IN_MEMORY_PAGES - sizeof (*mLoggerInfo);

0 commit comments

Comments
 (0)